diff options
author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-03 18:37:07 +0000 |
---|---|---|
committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-03 18:37:07 +0000 |
commit | 6ae2376f9dd54567691d732e698b4491a786e08d (patch) | |
tree | 2d0b0961abccd1969b22b99045dcc2230aa9b7ca /views | |
parent | f2b468ebe574b624abe10d2bb4448b81e5f9f98a (diff) | |
download | chromium_src-6ae2376f9dd54567691d732e698b4491a786e08d.zip chromium_src-6ae2376f9dd54567691d732e698b4491a786e08d.tar.gz chromium_src-6ae2376f9dd54567691d732e698b4491a786e08d.tar.bz2 |
A couple comment changes -- update an out of date comment and add a note about some awful behavior that dates back to the earliest days.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/185002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25338 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'views')
-rw-r--r-- | views/widget/widget_win.cc | 6 | ||||
-rw-r--r-- | views/widget/widget_win.h | 3 |
2 files changed, 7 insertions, 2 deletions
diff --git a/views/widget/widget_win.cc b/views/widget/widget_win.cc index f54da9a..1d8df95 100644 --- a/views/widget/widget_win.cc +++ b/views/widget/widget_win.cc @@ -504,6 +504,12 @@ void WidgetWin::OnKeyUp(TCHAR c, UINT rep_cnt, UINT flags) { SetMsgHandled(root_view_->ProcessKeyEvent(event)); } +// TODO(pkasting): ORing the pressed/released button into the flags is _wrong_. +// It makes it impossible to tell which button was modified when multiple +// buttons are/were held down. We need to instead put the modified button into +// a separate member on the MouseEvent, then audit all consumers of MouseEvents +// to fix them to use the resulting values correctly. + void WidgetWin::OnLButtonDown(UINT flags, const CPoint& point) { ProcessMousePressed(point, flags | MK_LBUTTON, false, false); } diff --git a/views/widget/widget_win.h b/views/widget/widget_win.h index 3fbcc93..8174511 100644 --- a/views/widget/widget_win.h +++ b/views/widget/widget_win.h @@ -453,8 +453,7 @@ class WidgetWin : public base::WindowImpl, virtual void OnFinalMessage(HWND window); // Start tracking all mouse events so that this window gets sent mouse leave - // messages too. |is_nonclient| is true when we should track WM_NCMOUSELEAVE - // messages instead of WM_MOUSELEAVE ones. + // messages too. void TrackMouseEvents(DWORD mouse_tracking_flags); // Actually handle mouse events. These functions are called by subclasses who |