summaryrefslogtreecommitdiffstats
path: root/webkit/api
diff options
context:
space:
mode:
authordarin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-10-03 05:01:26 +0000
committerdarin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-10-03 05:01:26 +0000
commit8922e1ff7ac33a3f88079e1e6d3ae8671602a952 (patch)
treea842ba34b909f84e7f3db6d60235504ad7887db2 /webkit/api
parent4b7d9b47a1adac0daa198761c01fc42ff1d9b394 (diff)
downloadchromium_src-8922e1ff7ac33a3f88079e1e6d3ae8671602a952.zip
chromium_src-8922e1ff7ac33a3f88079e1e6d3ae8671602a952.tar.gz
chromium_src-8922e1ff7ac33a3f88079e1e6d3ae8671602a952.tar.bz2
More WebView / WebViewDelegate cleanup.
Moves a bunch of methods from glue to the WebKit API. R=dglazkov BUG=10033 TEST=none Review URL: http://codereview.chromium.org/246079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27941 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/api')
-rw-r--r--webkit/api/public/WebFrameClient.h19
-rw-r--r--webkit/api/public/WebView.h9
-rw-r--r--webkit/api/public/WebViewClient.h12
3 files changed, 33 insertions, 7 deletions
diff --git a/webkit/api/public/WebFrameClient.h b/webkit/api/public/WebFrameClient.h
index 4d42965..6ef6e2d 100644
--- a/webkit/api/public/WebFrameClient.h
+++ b/webkit/api/public/WebFrameClient.h
@@ -50,6 +50,7 @@ namespace WebKit {
class WebWorker;
class WebWorkerClient;
struct WebPluginParams;
+ struct WebRect;
struct WebSize;
struct WebURLError;
@@ -221,8 +222,22 @@ namespace WebKit {
virtual void didChangeContentsSize(WebFrame*, const WebSize&) = 0;
- // FIXME need to add:
- // find-in-page
+ // Find-in-page notifications ------------------------------------------
+
+ // Notifies how many matches have been found so far, for a given
+ // identifier. |finalUpdate| specifies whether this is the last update
+ // (all frames have completed scoping).
+ virtual void reportFindInPageMatchCount(
+ int identifier, int count, bool finalUpdate) = 0;
+
+ // Notifies what tick-mark rect is currently selected. The given
+ // identifier lets the client know which request this message belongs
+ // to, so that it can choose to ignore the message if it has moved on
+ // to other things. The selection rect is expected to have coordinates
+ // relative to the top left corner of the web page area and represent
+ // where on the screen the selection rect is currently located.
+ virtual void reportFindInPageSelection(
+ int identifier, int activeMatchOrdinal, const WebRect& selection) = 0;
protected:
~WebFrameClient() { }
diff --git a/webkit/api/public/WebView.h b/webkit/api/public/WebView.h
index 7904f95e..bf7896d 100644
--- a/webkit/api/public/WebView.h
+++ b/webkit/api/public/WebView.h
@@ -188,12 +188,13 @@ namespace WebKit {
// point.
virtual void inspectElementAt(const WebPoint&) = 0;
+ // Settings used by the inspector.
+ virtual WebString inspectorSettings() const = 0;
+ virtual void setInspectorSettings(const WebString&) = 0;
+
// FIXME what about:
- // StoreFocusForFrame
- // DownloadImage
- // Get/SetDelegate
- // InsertText -> should move to WebTextInput
+ // GetDelegate
// AutofillSuggestionsForNode
// HideAutofillPopup
diff --git a/webkit/api/public/WebViewClient.h b/webkit/api/public/WebViewClient.h
index b4e8a47..60691fa 100644
--- a/webkit/api/public/WebViewClient.h
+++ b/webkit/api/public/WebViewClient.h
@@ -144,6 +144,9 @@ namespace WebKit {
// Show or hide the spelling UI.
virtual void showSpellingUI(bool show) = 0;
+ // Returns true if the spelling UI is showing.
+ virtual bool isShowingSpellingUI() = 0;
+
// Update the spelling UI with the given word.
virtual void updateSpellingUIWithMisspelledWord(const WebString& word) = 0;
@@ -215,7 +218,7 @@ namespace WebKit {
virtual void focusPrevious() = 0;
- // Session History -----------------------------------------------------
+ // Session history -----------------------------------------------------
// Tells the embedder to navigate back or forward in session history by
// the given offset (relative to the current position in session
@@ -231,6 +234,13 @@ namespace WebKit {
virtual void didAddHistoryItem() = 0;
+ // Developer tools -----------------------------------------------------
+
+ // Called to notify the client that the inspector's settings were
+ // changed and should be saved. See WebView::inspectorSettings.
+ virtual void didUpdateInspectorSettings() = 0;
+
+
// FIXME need to something for:
// OnPasswordFormsSeen
// OnAutofillFormSubmitted