diff options
| author | dpranke@google.com <dpranke@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-14 21:19:21 +0000 |
|---|---|---|
| committer | dpranke@google.com <dpranke@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-14 21:19:21 +0000 |
| commit | cf37da383867e81a5998fb06f5bca52dc92552c7 (patch) | |
| tree | f5cd435729061d74f739cadd0d51a09019c849c2 /webkit/api | |
| parent | a1b9f5d1be682acc27767c121e282b2353510b48 (diff) | |
| download | chromium_src-cf37da383867e81a5998fb06f5bca52dc92552c7.zip chromium_src-cf37da383867e81a5998fb06f5bca52dc92552c7.tar.gz chromium_src-cf37da383867e81a5998fb06f5bca52dc92552c7.tar.bz2 | |
This change adds a new "generic" theme to the Windows implementation of
test_shell, so that we can render controls in a platform-verion-independent
manner, allowing us to use (almost) a single set of baselines for all
versions of Windows.
test_shell is modified to accept three new switches: --ux-theme (for the
default or "new" XP/Vista theming engine), --classic-theme (for the older
"Classic" theming engine), and --generic-theme (for the new Skia-based
test theme). Specifying --layout-tests will default to --classic-theme,
otherwise --ux-theme is the default (this is compatible with existing
test_shell behavior). Once the new version-independent baselines are
checked in, we will flip this behavior so --layout-tests defaults to
--generic-theme as well.
This change adds test_shell_webtheme{engine,control}.{cc,h} as Windows-only
build files, and adds documentation to webkit/api/public/win/WebThemeEngine.
It also adds a chromium-win-xp platform baseline directory (currently empty)
and modifies the layout_test/layout_package/platform_utils_win.py baseline
search path to confirm to WebKit's directory search logic (vista and win7
look just in chromium-win, but XP looks in chromium-win-xp first, followed by
chromium-win).
BUG=none
R=darin,pkasting
TEST=none
Review URL: http://codereview.chromium.org/192021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26161 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/api')
| -rw-r--r-- | webkit/api/public/win/WebThemeEngine.h | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/webkit/api/public/win/WebThemeEngine.h b/webkit/api/public/win/WebThemeEngine.h index 0631950..423240a 100644 --- a/webkit/api/public/win/WebThemeEngine.h +++ b/webkit/api/public/win/WebThemeEngine.h @@ -1,10 +1,10 @@ /* * Copyright (C) 2009 Google Inc. All rights reserved. - * + * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are * met: - * + * * * Redistributions of source code must retain the above copyright * notice, this list of conditions and the following disclaimer. * * Redistributions in binary form must reproduce the above @@ -14,7 +14,7 @@ * * Neither the name of Google Inc. nor the names of its * contributors may be used to endorse or promote products derived from * this software without specific prior written permission. - * + * * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR @@ -38,8 +38,11 @@ namespace WebKit { struct WebRect; // The part and state parameters correspond to values defined by the - // Windows Theme API. The classicState parameter corresponds to the uState - // parameter of the Windows DrawFrameRect function. + // Windows Theme API (see + // http://msdn.microsoft.com/en-us/library/bb773187(VS.85).aspx ). + // The classicState parameter corresponds to the uState + // parameter of the Windows DrawFrameControl() function. + // See the definitions in <vsstyle.h> and <winuser.h>. class WebThemeEngine { public: virtual void paintButton( |