diff options
author | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-01 01:17:22 +0000 |
---|---|---|
committer | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-01 01:17:22 +0000 |
commit | 9c00acacfbd2742ff923b6f819c5aaf828348ca7 (patch) | |
tree | 2e7d81896791e0b914c0fa646ac798fea66c582b /webkit/appcache/appcache_host.h | |
parent | 60253bdae0411c6660b907744d10174a3c7d524a (diff) | |
download | chromium_src-9c00acacfbd2742ff923b6f819c5aaf828348ca7.zip chromium_src-9c00acacfbd2742ff923b6f819c5aaf828348ca7.tar.gz chromium_src-9c00acacfbd2742ff923b6f819c5aaf828348ca7.tar.bz2 |
Revert 33394 (due to valgrind errors) - Appcache update support for pending master entries:
Update process issues a URL request to fetch pending master entries.
Pending master entry fetch logic kept separate from regular url fetching as this will be the case in the longterm solution.
No optimizations to avoid issuing URL request if pending master entry is also listed in the manifest. (simpler)
Only optimized to prevent refetching something that has already been successfully fetched.
Longterm optimized solution should be to siphon the responses as the master resource is downloaded instead of having the update job issue URL requests.
TEST=new tests for update jobs with pending master entries
BUG=none
Review URL: http://codereview.chromium.org/402098
TBR=jennb@chromium.org
Review URL: http://codereview.chromium.org/449036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33405 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/appcache/appcache_host.h')
-rw-r--r-- | webkit/appcache/appcache_host.h | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/webkit/appcache/appcache_host.h b/webkit/appcache/appcache_host.h index f154bae..0622e3f 100644 --- a/webkit/appcache/appcache_host.h +++ b/webkit/appcache/appcache_host.h @@ -84,12 +84,6 @@ class AppCacheHost : public AppCacheStorage::Delegate, // Used to ensure that a loaded appcache survives a frame navigation. void LoadMainResourceCache(int64 cache_id); - // Used by the update job to keep track of which hosts are associated - // with which pending master entries. - const GURL& pending_master_entry_url() const { - return new_master_entry_url_; - } - int host_id() const { return host_id_; } AppCacheService* service() const { return service_; } AppCacheFrontend* frontend() const { return frontend_; } @@ -169,7 +163,6 @@ class AppCacheHost : public AppCacheStorage::Delegate, ObserverList<Observer> observers_; friend class AppCacheRequestHandlerTest; - friend class AppCacheUpdateJobTest; FRIEND_TEST(AppCacheTest, CleanupUnusedCache); FRIEND_TEST(AppCacheGroupTest, CleanupUnusedGroup); FRIEND_TEST(AppCacheHostTest, Basic); |