diff options
| author | michaeln@google.com <michaeln@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-12 20:26:04 +0000 |
|---|---|---|
| committer | michaeln@google.com <michaeln@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-12 20:26:04 +0000 |
| commit | f06b43b8bf588d08631f5d3dc196fd9c0e9df3c7 (patch) | |
| tree | c9ac43bc050ff591959e9ff4fd542bde192c708a /webkit/appcache/appcache_interfaces.cc | |
| parent | dcd23fee75c291fe9b5e7019e3ee31694442ff9e (diff) | |
| download | chromium_src-f06b43b8bf588d08631f5d3dc196fd9c0e9df3c7.zip chromium_src-f06b43b8bf588d08631f5d3dc196fd9c0e9df3c7.tar.gz chromium_src-f06b43b8bf588d08631f5d3dc196fd9c0e9df3c7.tar.bz2 | |
* Fix a bug with the applicationCache.status return value. The wrong status value was visible via applicationCache.status after a swap because we sample GetStatus() before swappable_cache_ was cleared out.
* Pull the plug on support for file:// urls in DEBUG builds for now.
TEST=added to appcache_host_unittest.cc
BUG=none
Review URL: http://codereview.chromium.org/385071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31818 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/appcache/appcache_interfaces.cc')
| -rw-r--r-- | webkit/appcache/appcache_interfaces.cc | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/webkit/appcache/appcache_interfaces.cc b/webkit/appcache/appcache_interfaces.cc index d48f342..4ee686a 100644 --- a/webkit/appcache/appcache_interfaces.cc +++ b/webkit/appcache/appcache_interfaces.cc @@ -22,7 +22,13 @@ const char kHttpHEADMethod[] = "HEAD"; bool IsSchemeSupported(const GURL& url) { bool supported = url.SchemeIs(kHttpScheme) || url.SchemeIs(kHttpsScheme); #ifndef NDEBUG - supported |= url.SchemeIsFile(); + // TODO(michaeln): It would be really nice if this could optionally work for + // file urls too to help web developers experiment and test their apps, + // perhaps enabled via a cmd line flag or some other developer tool setting. + // Unfortunately file scheme URLRequest don't produce the same signalling + // (200 response codes, headers) as http URLRequests, so this doesn't work + // just yet. + // supported |= url.SchemeIsFile(); #endif return supported; } |