summaryrefslogtreecommitdiffstats
path: root/webkit/appcache/appcache_response.h
diff options
context:
space:
mode:
authorerg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2010-09-30 20:06:30 +0000
committererg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2010-09-30 20:06:30 +0000
commit20f0487a5b73e8071af2612150301b0942cbf0e2 (patch)
treeecee69b28f16712bdc1558ac0a015ac80095c761 /webkit/appcache/appcache_response.h
parent167b0dd17d5ed57ff293b6480ccaed706e0bc9cb (diff)
downloadchromium_src-20f0487a5b73e8071af2612150301b0942cbf0e2.zip
chromium_src-20f0487a5b73e8071af2612150301b0942cbf0e2.tar.gz
chromium_src-20f0487a5b73e8071af2612150301b0942cbf0e2.tar.bz2
FBTF: Move ctors/dtors into implementation files. Adds ctors/dtors to non-POD structs.
Cuts ~2MB off our .a files (Debug, Linux). Also added the "virtual" keyword on a whole bunch of virtual dtors that were missing it. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3522004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61100 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/appcache/appcache_response.h')
-rw-r--r--webkit/appcache/appcache_response.h11
1 files changed, 4 insertions, 7 deletions
diff --git a/webkit/appcache/appcache_response.h b/webkit/appcache/appcache_response.h
index 1f8ecce..5f62b14 100644
--- a/webkit/appcache/appcache_response.h
+++ b/webkit/appcache/appcache_response.h
@@ -48,7 +48,7 @@ class AppCacheResponseInfo
private:
friend class base::RefCounted<AppCacheResponseInfo>;
- ~AppCacheResponseInfo();
+ virtual ~AppCacheResponseInfo();
const GURL manifest_url_;
const int64 response_id_;
@@ -64,15 +64,12 @@ struct HttpResponseInfoIOBuffer
scoped_ptr<net::HttpResponseInfo> http_info;
int response_data_size;
- HttpResponseInfoIOBuffer()
- : response_data_size(kUnkownResponseDataSize) {}
- explicit HttpResponseInfoIOBuffer(net::HttpResponseInfo* info)
- : http_info(info), response_data_size(kUnkownResponseDataSize) {}
+ HttpResponseInfoIOBuffer();
+ explicit HttpResponseInfoIOBuffer(net::HttpResponseInfo* info);
private:
friend class base::RefCountedThreadSafe<HttpResponseInfoIOBuffer>;
-
- ~HttpResponseInfoIOBuffer() {}
+ virtual ~HttpResponseInfoIOBuffer();
};
// Common base class for response reader and writer.