diff options
author | michaeln@google.com <michaeln@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-29 03:37:22 +0000 |
---|---|---|
committer | michaeln@google.com <michaeln@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-29 03:37:22 +0000 |
commit | 833a4baa2ccf968616d72361a74852c57f911d96 (patch) | |
tree | 07ccc3df12e7800ef381dd14ca2bda4e8760aa81 /webkit/appcache/mock_appcache_storage.cc | |
parent | 5ac84ca4f92eea80f31b5c7a58e41e35657a69ab (diff) | |
download | chromium_src-833a4baa2ccf968616d72361a74852c57f911d96.zip chromium_src-833a4baa2ccf968616d72361a74852c57f911d96.tar.gz chromium_src-833a4baa2ccf968616d72361a74852c57f911d96.tar.bz2 |
Revert 35328 - AppCacheDatabase and SQL based AppCacheStorageImpl.
Still nothing is being written to disk with this CL,
inmemory SQLite and DiskCaches are being utilized.
Responses are not yet being removed from the DiskCasche
when the should be. Once that's done (in the next CL), we'll
start saving things on disk.
BUG=none
TEST=appcache_database_unittest.cc, appcache_storage_impl_unittest.cc
Review URL: http://codereview.chromium.org/501033
TBR=michaeln@chromium.org
Review URL: http://codereview.chromium.org/519018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35329 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/appcache/mock_appcache_storage.cc')
-rw-r--r-- | webkit/appcache/mock_appcache_storage.cc | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/webkit/appcache/mock_appcache_storage.cc b/webkit/appcache/mock_appcache_storage.cc index 44bcd12..214be249 100644 --- a/webkit/appcache/mock_appcache_storage.cc +++ b/webkit/appcache/mock_appcache_storage.cc @@ -124,6 +124,8 @@ void MockAppCacheStorage::MarkEntryAsForeign( if (entry) entry->add_types(AppCacheEntry::FOREIGN); } + // TODO(michaeln): in real storage update in storage, and if this cache is + // being loaded be sure to update the memory cache upon load completion. } void MockAppCacheStorage::MakeGroupObsolete( @@ -138,7 +140,7 @@ void MockAppCacheStorage::MakeGroupObsolete( } AppCacheResponseReader* MockAppCacheStorage::CreateResponseReader( - const GURL& manifest_url, int64 response_id) { + const GURL& origin, int64 response_id) { return new AppCacheResponseReader(response_id, disk_cache()); } @@ -201,6 +203,14 @@ void MockAppCacheStorage::ProcessStoreGroupAndNewestCache( if (delegate_ref->delegate) delegate_ref->delegate->OnGroupAndNewestCacheStored(group, true); + + // We don't bother with removing responses from 'mock' storage + // TODO(michaeln): for 'real' storage... + // std::set<int64> doomed_responses_ = responses from old caches + // std::set<int64> needed_responses_ = responses from newest cache + // foreach(needed_responses_) + // doomed_responses_.remove(needed_response_); + // DoomResponses(group->manifest_url(), doomed_responses_); } namespace { |