diff options
| author | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-09 22:30:15 +0000 |
|---|---|---|
| committer | evan@chromium.org <evan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-09 22:30:15 +0000 |
| commit | 7783ad3f2317054bccfae7c0be3e4c8c65766a79 (patch) | |
| tree | 16e7ec2e6d09999863f9ee313b89dc2a7e5940d7 /webkit/appcache | |
| parent | 731de025a4532107ff9f56a5320f30ec82b2bdea (diff) | |
| download | chromium_src-7783ad3f2317054bccfae7c0be3e4c8c65766a79.zip chromium_src-7783ad3f2317054bccfae7c0be3e4c8c65766a79.tar.gz chromium_src-7783ad3f2317054bccfae7c0be3e4c8c65766a79.tar.bz2 | |
appcache: document that the manifest parsing algorithm is fixed
Otherwise, people (like me) will attempt to "moderize" this code
and discover that it's fine the way it is. :~(
TEST=compiles (just adding a comment)
Review URL: http://codereview.chromium.org/5742002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68775 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/appcache')
| -rw-r--r-- | webkit/appcache/manifest_parser.cc | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/webkit/appcache/manifest_parser.cc b/webkit/appcache/manifest_parser.cc index 68b37d8..49ddd8c 100644 --- a/webkit/appcache/manifest_parser.cc +++ b/webkit/appcache/manifest_parser.cc @@ -51,6 +51,13 @@ Manifest::~Manifest() {} bool ParseManifest(const GURL& manifest_url, const char* data, int length, Manifest& manifest) { + // This is an implementation of the parsing algorithm specified in + // the HTML5 offline web application docs: + // http://www.w3.org/TR/html5/offline.html + // Do not modify it without consulting those docs. + // Though you might be tempted to convert these wstrings to UTF-8 or + // string16, this implementation seems simpler given the constraints. + static const std::wstring kSignature(L"CACHE MANIFEST"); DCHECK(manifest.explicit_urls.empty()); |