Clean-up inline members of nested classes (webkit/)

Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.

The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.

BUG=139346


Review URL: https://chromiumcodereview.appspot.com/10829258

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150912 0039d316-1c4b-4281-b951-d872f2087c98

2 files changed, 18 insertions, 13 deletions

diff --git a/webkit/appcache/appcache_disk_cache.cc b/webkit/appcache/appcache_disk_cache.cc
index 79ab58b..88bea87 100644
--- a/webkit/appcache/appcache_disk_cache.cc
+++ b/webkit/appcache/appcache_disk_cache.cc
@@ -243,6 +243,22 @@ int AppCacheDiskCache::DoomEntry(int64 key,
   return (new ActiveCall(this))->DoomEntry(key, callback);
 }
 
+AppCacheDiskCache::PendingCall::PendingCall()
+    : call_type(CREATE),
+      key(0),
+      entry(NULL) {
+}
+
+AppCacheDiskCache::PendingCall::PendingCall(PendingCallType call_type,
+    int64 key,
+    Entry** entry,
+    const net::CompletionCallback& callback)
+    : call_type(call_type),
+      key(key),
+      entry(entry),
+      callback(callback) {
+}
+
 AppCacheDiskCache::PendingCall::~PendingCall() {}
 
 int AppCacheDiskCache::Init(net::CacheType cache_type,
@@ -304,4 +320,3 @@ void AppCacheDiskCache::OnCreateBackendComplete(int rv) {
 }
 
 }  // namespace appcache
-
diff --git a/webkit/appcache/appcache_disk_cache.h b/webkit/appcache/appcache_disk_cache.h
index b361793..27e8905 100644
--- a/webkit/appcache/appcache_disk_cache.h
+++ b/webkit/appcache/appcache_disk_cache.h
@@ -64,19 +64,10 @@ class APPCACHE_EXPORT AppCacheDiskCache
     Entry** entry;
     net::CompletionCallback callback;
 
-    PendingCall()
-        : call_type(CREATE),
-          key(0),
-          entry(NULL) {
-    }
+    PendingCall();
 
     PendingCall(PendingCallType call_type, int64 key,
-                Entry** entry, const net::CompletionCallback& callback)
-        : call_type(call_type),
-          key(key),
-          entry(entry),
-          callback(callback) {
-    }
+                Entry** entry, const net::CompletionCallback& callback);
 
     ~PendingCall();
   };
@@ -107,4 +98,3 @@ class APPCACHE_EXPORT AppCacheDiskCache
 }  // namespace appcache
 
 #endif  // WEBKIT_APPCACHE_APPCACHE_DISK_CACHE_H_
-