Virtual destructors should have virtual keyword.

Make sure user-declared virtual destructors always have the virtual keyword.
The Clang style-check plugin will check for this soon.

No functionality change: virtual is only added
to destructors that are already implicitly virtual.

Also fix a couple of in-line destructor definitions.

BUG=83408
TEST=none

Review URL: http://codereview.chromium.org/7064033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86587 0039d316-1c4b-4281-b951-d872f2087c98

4 files changed, 5 insertions, 5 deletions

diff --git a/webkit/appcache/appcache_disk_cache.h b/webkit/appcache/appcache_disk_cache.h
index 1799813..404da05 100644
--- a/webkit/appcache/appcache_disk_cache.h
+++ b/webkit/appcache/appcache_disk_cache.h
@@ -57,7 +57,7 @@ class AppCacheDiskCache {
 
     disk_cache::Backend* backend_ptr_;  // Accessed directly.
    private:
-    ~CreateBackendCallback() {
+    virtual ~CreateBackendCallback() {
       delete backend_ptr_;
     }
   };
diff --git a/webkit/appcache/appcache_host.h b/webkit/appcache/appcache_host.h
index a06cdd3..0f8ac47 100644
--- a/webkit/appcache/appcache_host.h
+++ b/webkit/appcache/appcache_host.h
@@ -48,7 +48,7 @@ class AppCacheHost : public AppCacheStorage::Delegate,
 
   AppCacheHost(int host_id, AppCacheFrontend* frontend,
                AppCacheService* service);
-  ~AppCacheHost();
+  virtual ~AppCacheHost();
 
   // Adds/removes an observer, the AppCacheHost does not take
   // ownership of the observer.
diff --git a/webkit/appcache/appcache_update_job.h b/webkit/appcache/appcache_update_job.h
index 04c3c80..b85d73b 100644
--- a/webkit/appcache/appcache_update_job.h
+++ b/webkit/appcache/appcache_update_job.h
@@ -33,7 +33,7 @@ class AppCacheUpdateJob : public AppCacheStorage::Delegate,
                           public AppCacheHost::Observer {
  public:
   AppCacheUpdateJob(AppCacheService* service, AppCacheGroup* group);
-  ~AppCacheUpdateJob();
+  virtual ~AppCacheUpdateJob();
 
   // Triggers the update process or adds more info if this update is already
   // in progress.
@@ -101,7 +101,7 @@ class AppCacheUpdateJob : public AppCacheStorage::Delegate,
     URLFetcher(const GURL& url,
                FetchType fetch_type,
                AppCacheUpdateJob* job);
-    ~URLFetcher();
+    virtual ~URLFetcher();
     void Start();
     FetchType fetch_type() const { return fetch_type_; }
     net::URLRequest* request() const { return request_.get(); }
diff --git a/webkit/appcache/view_appcache_internals_job.h b/webkit/appcache/view_appcache_internals_job.h
index de2c736..8995713 100644
--- a/webkit/appcache/view_appcache_internals_job.h
+++ b/webkit/appcache/view_appcache_internals_job.h
@@ -34,7 +34,7 @@ class ViewAppCacheInternalsJob : public net::URLRequestSimpleJob {
   virtual bool IsRedirectResponse(GURL* location, int* http_status_code);
 
  private:
-  ~ViewAppCacheInternalsJob();
+  virtual ~ViewAppCacheInternalsJob();
 
   void AppCacheDone(int rv);