diff options
author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-01-08 01:22:15 +0000 |
---|---|---|
committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-01-08 01:22:15 +0000 |
commit | 810a52ef77564f1674a600317175743176bcc965 (patch) | |
tree | e18a35b4ef980bdb8eaad3c5812228a6e1b3ba16 /webkit/appcache | |
parent | 673ccc1d607a6d7d280d89fedd3fb3bc906a7e27 (diff) | |
download | chromium_src-810a52ef77564f1674a600317175743176bcc965.zip chromium_src-810a52ef77564f1674a600317175743176bcc965.tar.gz chromium_src-810a52ef77564f1674a600317175743176bcc965.tar.bz2 |
Remove most uses of EmptyString(), EmptyWString(), EmptyString16(), and EmptyGURL(), since the code in question can just use the default constructor.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/517054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35766 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/appcache')
-rw-r--r-- | webkit/appcache/appcache_group.h | 4 | ||||
-rw-r--r-- | webkit/appcache/appcache_host.cc | 10 | ||||
-rw-r--r-- | webkit/appcache/appcache_host_unittest.cc | 7 | ||||
-rw-r--r-- | webkit/appcache/appcache_request_handler.cc | 4 | ||||
-rw-r--r-- | webkit/appcache/appcache_storage_impl.cc | 4 | ||||
-rw-r--r-- | webkit/appcache/appcache_storage_unittest.cc | 10 | ||||
-rw-r--r-- | webkit/appcache/appcache_update_job_unittest.cc | 70 | ||||
-rw-r--r-- | webkit/appcache/appcache_url_request_job_unittest.cc | 4 | ||||
-rw-r--r-- | webkit/appcache/manifest_parser_unittest.cc | 4 | ||||
-rw-r--r-- | webkit/appcache/mock_appcache_storage.cc | 5 | ||||
-rw-r--r-- | webkit/appcache/web_application_cache_host_impl.cc | 4 |
11 files changed, 61 insertions, 65 deletions
diff --git a/webkit/appcache/appcache_group.h b/webkit/appcache/appcache_group.h index 5cf3d99..e6f8972 100644 --- a/webkit/appcache/appcache_group.h +++ b/webkit/appcache/appcache_group.h @@ -1,4 +1,4 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -70,7 +70,7 @@ class AppCacheGroup : public base::RefCounted<AppCacheGroup> { // Starts an update for a doc loaded from an application cache. void StartUpdateWithHost(AppCacheHost* host) { - StartUpdateWithNewMasterEntry(host, GURL::EmptyGURL()); + StartUpdateWithNewMasterEntry(host, GURL()); } // Starts an update for a doc loaded using HTTP GET or equivalent with diff --git a/webkit/appcache/appcache_host.cc b/webkit/appcache/appcache_host.cc index d35d61a..58212f5 100644 --- a/webkit/appcache/appcache_host.cc +++ b/webkit/appcache/appcache_host.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -54,12 +54,12 @@ void AppCacheHost::SelectCache(const GURL& document_url, // if the resulting behavior is just too insane). if (is_selection_pending()) { service_->storage()->CancelDelegateCallbacks(this); - pending_selected_manifest_url_ = GURL::EmptyGURL(); + pending_selected_manifest_url_ = GURL(); pending_selected_cache_id_ = kNoCacheId; } else if (associated_cache()) { AssociateCache(NULL); } - new_master_entry_url_ = GURL::EmptyGURL(); + new_master_entry_url_ = GURL(); // 6.9.6 The application cache selection algorithm. // The algorithm is started here and continues in FinishCacheSelection, @@ -93,7 +93,7 @@ void AppCacheHost::MarkAsForeignEntry(const GURL& document_url, int64 cache_document_was_loaded_from) { service_->storage()->MarkEntryAsForeign( document_url, cache_document_was_loaded_from); - SelectCache(document_url, kNoCacheId, GURL::EmptyGURL()); + SelectCache(document_url, kNoCacheId, GURL()); } void AppCacheHost::GetStatusWithCallback(GetStatusCallback* callback, @@ -236,7 +236,7 @@ void AppCacheHost::LoadOrCreateGroup(const GURL& manifest_url) { void AppCacheHost::OnGroupLoaded(AppCacheGroup* group, const GURL& manifest_url) { DCHECK(manifest_url == pending_selected_manifest_url_); - pending_selected_manifest_url_ = GURL::EmptyGURL(); + pending_selected_manifest_url_ = GURL(); FinishCacheSelection(NULL, group); } diff --git a/webkit/appcache/appcache_host_unittest.cc b/webkit/appcache/appcache_host_unittest.cc index 3ded220..687125b 100644 --- a/webkit/appcache/appcache_host_unittest.cc +++ b/webkit/appcache/appcache_host_unittest.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -122,7 +122,7 @@ TEST_F(AppCacheHostTest, SelectNoCache) { mock_frontend_.last_status_ = OBSOLETE; AppCacheHost host(1, &mock_frontend_, &service_); - host.SelectCache(GURL("http://whatever/"), kNoCacheId, GURL::EmptyGURL()); + host.SelectCache(GURL("http://whatever/"), kNoCacheId, GURL()); // We should have received an OnCacheSelected msg EXPECT_EQ(1, mock_frontend_.last_host_id_); @@ -235,8 +235,7 @@ TEST_F(AppCacheHostTest, SetSwappableCache) { EXPECT_FALSE(host.swappable_cache_.get()); scoped_refptr<AppCacheGroup> group1 = - new AppCacheGroup(&service_, GURL::EmptyGURL(), - service_.storage()->NewGroupId()); + new AppCacheGroup(&service_, GURL(), service_.storage()->NewGroupId()); host.SetSwappableCache(group1); EXPECT_FALSE(host.swappable_cache_.get()); diff --git a/webkit/appcache/appcache_request_handler.cc b/webkit/appcache/appcache_request_handler.cc index 068535e..a17e7e5 100644 --- a/webkit/appcache/appcache_request_handler.cc +++ b/webkit/appcache/appcache_request_handler.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -63,7 +63,7 @@ AppCacheURLRequestJob* AppCacheRequestHandler::MaybeLoadResource( found_entry_ = AppCacheEntry(); found_fallback_entry_ = AppCacheEntry(); found_cache_id_ = kNoCacheId; - found_manifest_url_ = GURL::EmptyGURL(); + found_manifest_url_ = GURL(); found_network_namespace_ = false; if (is_main_request_) diff --git a/webkit/appcache/appcache_storage_impl.cc b/webkit/appcache/appcache_storage_impl.cc index 06e88db..44c2365 100644 --- a/webkit/appcache/appcache_storage_impl.cc +++ b/webkit/appcache/appcache_storage_impl.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -765,7 +765,7 @@ void AppCacheStorageImpl::DeliverShortCircuitedFindMainResponse( delegate_ref->delegate->OnMainResponseFound( url, found_entry, AppCacheEntry(), cache.get() ? cache->cache_id() : kNoCacheId, - group.get() ? group->manifest_url() : GURL::EmptyGURL()); + group.get() ? group->manifest_url() : GURL()); } } diff --git a/webkit/appcache/appcache_storage_unittest.cc b/webkit/appcache/appcache_storage_unittest.cc index 083d566..65f3064 100644 --- a/webkit/appcache/appcache_storage_unittest.cc +++ b/webkit/appcache/appcache_storage_unittest.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -37,15 +37,13 @@ TEST_F(AppCacheStorageTest, AddRemoveCache) { TEST_F(AppCacheStorageTest, AddRemoveGroup) { MockAppCacheService service; - scoped_refptr<AppCacheGroup> group = - new AppCacheGroup(&service, GURL::EmptyGURL(), 111); + scoped_refptr<AppCacheGroup> group = new AppCacheGroup(&service, GURL(), 111); - EXPECT_EQ(group.get(), - service.storage()->working_set()->GetGroup(GURL::EmptyGURL())); + EXPECT_EQ(group.get(), service.storage()->working_set()->GetGroup(GURL())); service.storage()->working_set()->RemoveGroup(group); - EXPECT_TRUE(!service.storage()->working_set()->GetGroup(GURL::EmptyGURL())); + EXPECT_TRUE(!service.storage()->working_set()->GetGroup(GURL())); // Removing non-existing group from service should not fail. MockAppCacheService dummy; diff --git a/webkit/appcache/appcache_update_job_unittest.cc b/webkit/appcache/appcache_update_job_unittest.cc index 4ed1224..b789710 100644 --- a/webkit/appcache/appcache_update_job_unittest.cc +++ b/webkit/appcache/appcache_update_job_unittest.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -41,7 +41,7 @@ class MockFrontend : public AppCacheFrontend { it != update_hosts_.end(); ++it) { AppCacheHost* host = *it; update_->StartUpdate(host, - (host ? host->pending_master_entry_url() : GURL::EmptyGURL())); + (host ? host->pending_master_entry_url() : GURL())); } update_hosts_.clear(); // only trigger once } @@ -327,7 +327,7 @@ class AppCacheUpdateJobTest : public testing::Test, MockFrontend mock_frontend; AppCacheHost host(1, &mock_frontend, service_.get()); - update->StartUpdate(&host, GURL::EmptyGURL()); + update->StartUpdate(&host, GURL()); // Verify state. EXPECT_EQ(AppCacheUpdateJob::CACHE_ATTEMPT, update->update_type_); @@ -377,7 +377,7 @@ class AppCacheUpdateJobTest : public testing::Test, AppCacheUpdateJob* update = new AppCacheUpdateJob(service_.get(), group_); group_->update_job_ = update; - update->StartUpdate(&host4, GURL::EmptyGURL()); + update->StartUpdate(&host4, GURL()); // Verify state after starting an update. EXPECT_EQ(AppCacheUpdateJob::UPGRADE_ATTEMPT, update->update_type_); @@ -424,7 +424,7 @@ class AppCacheUpdateJobTest : public testing::Test, MockFrontend* frontend = MakeMockFrontend(); AppCacheHost* host = MakeHost(1, frontend); - update->StartUpdate(host, GURL::EmptyGURL()); + update->StartUpdate(host, GURL()); EXPECT_TRUE(update->manifest_url_request_ != NULL); update->manifest_url_request_->SimulateError(-100); @@ -456,7 +456,7 @@ class AppCacheUpdateJobTest : public testing::Test, host1->AssociateCache(cache); host2->AssociateCache(cache); - update->StartUpdate(NULL, GURL::EmptyGURL()); + update->StartUpdate(NULL, GURL()); EXPECT_TRUE(update->manifest_url_request_ != NULL); update->manifest_url_request_->SimulateError(-100); @@ -491,7 +491,7 @@ class AppCacheUpdateJobTest : public testing::Test, MockFrontend* frontend = MakeMockFrontend(); AppCacheHost* host = MakeHost(1, frontend); - update->StartUpdate(host, GURL::EmptyGURL()); + update->StartUpdate(host, GURL()); EXPECT_TRUE(update->manifest_url_request_ != NULL); // Set up checks for when update job finishes. @@ -516,7 +516,7 @@ class AppCacheUpdateJobTest : public testing::Test, MockFrontend* frontend = MakeMockFrontend(); AppCacheHost* host = MakeHost(1, frontend); - update->StartUpdate(host, GURL::EmptyGURL()); + update->StartUpdate(host, GURL()); EXPECT_TRUE(update->manifest_url_request_ != NULL); // Set up checks for when update job finishes. @@ -547,7 +547,7 @@ class AppCacheUpdateJobTest : public testing::Test, host1->AssociateCache(cache); host2->AssociateCache(cache); - update->StartUpdate(NULL, GURL::EmptyGURL()); + update->StartUpdate(NULL, GURL()); EXPECT_TRUE(update->manifest_url_request_ != NULL); // Set up checks for when update job finishes. @@ -577,7 +577,7 @@ class AppCacheUpdateJobTest : public testing::Test, MockFrontend* frontend = MakeMockFrontend(); AppCacheHost* host = MakeHost(1, frontend); - update->StartUpdate(host, GURL::EmptyGURL()); + update->StartUpdate(host, GURL()); EXPECT_TRUE(update->manifest_url_request_ != NULL); // Set up checks for when update job finishes. @@ -602,7 +602,7 @@ class AppCacheUpdateJobTest : public testing::Test, MockFrontend* frontend = MakeMockFrontend(); AppCacheHost* host = MakeHost(1, frontend); - update->StartUpdate(host, GURL::EmptyGURL()); + update->StartUpdate(host, GURL()); EXPECT_TRUE(update->manifest_url_request_ != NULL); // Set up checks for when update job finishes. @@ -633,7 +633,7 @@ class AppCacheUpdateJobTest : public testing::Test, host1->AssociateCache(cache); host2->AssociateCache(cache); - update->StartUpdate(NULL, GURL::EmptyGURL()); + update->StartUpdate(NULL, GURL()); EXPECT_TRUE(update->manifest_url_request_ != NULL); // Set up checks for when update job finishes. @@ -710,7 +710,7 @@ class AppCacheUpdateJobTest : public testing::Test, response_writer_.reset(); AppCacheUpdateJob* update = group_->update_job_; - update->StartUpdate(NULL, GURL::EmptyGURL()); + update->StartUpdate(NULL, GURL()); EXPECT_TRUE(update->manifest_url_request_ != NULL); WaitForUpdateToFinish(); @@ -728,7 +728,7 @@ class AppCacheUpdateJobTest : public testing::Test, MockFrontend* frontend = MakeMockFrontend(); AppCacheHost* host = MakeHost(1, frontend); - update->StartUpdate(host, GURL::EmptyGURL()); + update->StartUpdate(host, GURL()); EXPECT_TRUE(update->manifest_url_request_ != NULL); // Set up checks for when update job finishes. @@ -998,7 +998,7 @@ class AppCacheUpdateJobTest : public testing::Test, cache->AddEntry(http_server_->TestServerPage("files/explicit1"), AppCacheEntry(AppCacheEntry::MASTER, 111)); - update->StartUpdate(NULL, GURL::EmptyGURL()); + update->StartUpdate(NULL, GURL()); EXPECT_TRUE(update->manifest_url_request_ != NULL); // Set up checks for when update job finishes. @@ -1039,7 +1039,7 @@ class AppCacheUpdateJobTest : public testing::Test, MockFrontend* frontend = MakeMockFrontend(); AppCacheHost* host = MakeHost(1, frontend); - update->StartUpdate(host, GURL::EmptyGURL()); + update->StartUpdate(host, GURL()); EXPECT_TRUE(update->manifest_url_request_ != NULL); // Set up checks for when update job finishes. @@ -1070,7 +1070,7 @@ class AppCacheUpdateJobTest : public testing::Test, host1->AssociateCache(cache); host2->AssociateCache(cache); - update->StartUpdate(NULL, GURL::EmptyGURL()); + update->StartUpdate(NULL, GURL()); EXPECT_TRUE(update->manifest_url_request_ != NULL); // Set up checks for when update job finishes. @@ -1125,7 +1125,7 @@ class AppCacheUpdateJobTest : public testing::Test, http_server_->TestServerPage("files/servererror"), AppCacheEntry(AppCacheEntry::MASTER, 444)); - update->StartUpdate(NULL, GURL::EmptyGURL()); + update->StartUpdate(NULL, GURL()); EXPECT_TRUE(update->manifest_url_request_ != NULL); // Set up checks for when update job finishes. @@ -1188,7 +1188,7 @@ class AppCacheUpdateJobTest : public testing::Test, host1->AssociateCache(cache); host2->AssociateCache(cache); - update->StartUpdate(NULL, GURL::EmptyGURL()); + update->StartUpdate(NULL, GURL()); EXPECT_TRUE(update->manifest_url_request_ != NULL); // Set up checks for when update job finishes. @@ -1224,7 +1224,7 @@ class AppCacheUpdateJobTest : public testing::Test, AppCacheHost* host = MakeHost(1, frontend); host->AssociateCache(cache); - update->StartUpdate(host, GURL::EmptyGURL()); + update->StartUpdate(host, GURL()); EXPECT_TRUE(update->manifest_url_request_ != NULL); // Set up checks for when update job finishes. @@ -1259,7 +1259,7 @@ class AppCacheUpdateJobTest : public testing::Test, MockFrontend* frontend = MakeMockFrontend(); AppCacheHost* host = MakeHost(1, frontend); - update->StartUpdate(host, GURL::EmptyGURL()); + update->StartUpdate(host, GURL()); EXPECT_TRUE(update->manifest_url_request_ != NULL); // Set up checks for when update job finishes. @@ -1290,7 +1290,7 @@ class AppCacheUpdateJobTest : public testing::Test, MockFrontend* frontend = MakeMockFrontend(); AppCacheHost* host = MakeHost(1, frontend); - update->StartUpdate(host, GURL::EmptyGURL()); + update->StartUpdate(host, GURL()); EXPECT_TRUE(update->manifest_url_request_ != NULL); // Set up checks for when update job finishes. @@ -1322,7 +1322,7 @@ class AppCacheUpdateJobTest : public testing::Test, MockFrontend* frontend = MakeMockFrontend(); AppCacheHost* host = MakeHost(1, frontend); - update->StartUpdate(host, GURL::EmptyGURL()); + update->StartUpdate(host, GURL()); EXPECT_TRUE(update->manifest_url_request_ != NULL); // Set up checks for when update job finishes. @@ -1353,7 +1353,7 @@ class AppCacheUpdateJobTest : public testing::Test, MockFrontend* frontend = MakeMockFrontend(); AppCacheHost* host = MakeHost(1, frontend); - update->StartUpdate(host, GURL::EmptyGURL()); + update->StartUpdate(host, GURL()); EXPECT_TRUE(update->manifest_url_request_ != NULL); // Set up checks for when update job finishes. @@ -1384,7 +1384,7 @@ class AppCacheUpdateJobTest : public testing::Test, MockFrontend* frontend = MakeMockFrontend(); AppCacheHost* host = MakeHost(1, frontend); - update->StartUpdate(host, GURL::EmptyGURL()); + update->StartUpdate(host, GURL()); EXPECT_TRUE(update->manifest_url_request_ != NULL); // Set up checks for when update job finishes. @@ -1413,7 +1413,7 @@ class AppCacheUpdateJobTest : public testing::Test, MockFrontend* frontend = MakeMockFrontend(); AppCacheHost* host = MakeHost(1, frontend); - update->StartUpdate(host, GURL::EmptyGURL()); + update->StartUpdate(host, GURL()); // Set up checks for when update job finishes. do_checks_after_update_finished_ = true; @@ -1447,7 +1447,7 @@ class AppCacheUpdateJobTest : public testing::Test, host1->AssociateCache(cache); host2->AssociateCache(cache); - update->StartUpdate(NULL, GURL::EmptyGURL()); + update->StartUpdate(NULL, GURL()); // Set up checks for when update job finishes. do_checks_after_update_finished_ = true; @@ -1486,7 +1486,7 @@ class AppCacheUpdateJobTest : public testing::Test, MockFrontend* frontend = MakeMockFrontend(); AppCacheHost* host = MakeHost(1, frontend); - update->StartUpdate(host, GURL::EmptyGURL()); + update->StartUpdate(host, GURL()); EXPECT_TRUE(update->manifest_url_request_ != NULL); // Set up checks for when update job finishes. @@ -1521,7 +1521,7 @@ class AppCacheUpdateJobTest : public testing::Test, host1->AssociateCache(cache); host2->AssociateCache(cache); - update->StartUpdate(NULL, GURL::EmptyGURL()); + update->StartUpdate(NULL, GURL()); EXPECT_TRUE(update->manifest_url_request_ != NULL); // Set up checks for when update job finishes. @@ -2072,7 +2072,7 @@ class AppCacheUpdateJobTest : public testing::Test, AppCacheHost* host1 = MakeHost(1, frontend1); host1->AssociateCache(cache); - update->StartUpdate(NULL, GURL::EmptyGURL()); + update->StartUpdate(NULL, GURL()); // Set up additional updates to be started while update is in progress. MockFrontend* frontend2 = MakeMockFrontend(); @@ -2199,7 +2199,7 @@ class AppCacheUpdateJobTest : public testing::Test, HttpHeadersRequestTestJob::Initialize("", ""); MockFrontend mock_frontend; AppCacheHost host(1, &mock_frontend, service_.get()); - update->StartUpdate(&host, GURL::EmptyGURL()); + update->StartUpdate(&host, GURL()); HttpHeadersRequestTestJob::Verify(); delete update; @@ -2801,12 +2801,12 @@ TEST_F(AppCacheUpdateJobTest, AlreadyChecking) { group->update_job_ = &update; group->update_status_ = AppCacheGroup::CHECKING; - update.StartUpdate(NULL, GURL::EmptyGURL()); + update.StartUpdate(NULL, GURL()); EXPECT_EQ(AppCacheGroup::CHECKING, group->update_status()); MockFrontend mock_frontend; AppCacheHost host(1, &mock_frontend, &service); - update.StartUpdate(&host, GURL::EmptyGURL()); + update.StartUpdate(&host, GURL()); MockFrontend::RaisedEvents events = mock_frontend.raised_events_; size_t expected = 1; @@ -2829,12 +2829,12 @@ TEST_F(AppCacheUpdateJobTest, AlreadyDownloading) { group->update_job_ = &update; group->update_status_ = AppCacheGroup::DOWNLOADING; - update.StartUpdate(NULL, GURL::EmptyGURL()); + update.StartUpdate(NULL, GURL()); EXPECT_EQ(AppCacheGroup::DOWNLOADING, group->update_status()); MockFrontend mock_frontend; AppCacheHost host(1, &mock_frontend, &service); - update.StartUpdate(&host, GURL::EmptyGURL()); + update.StartUpdate(&host, GURL()); MockFrontend::RaisedEvents events = mock_frontend.raised_events_; size_t expected = 2; diff --git a/webkit/appcache/appcache_url_request_job_unittest.cc b/webkit/appcache/appcache_url_request_job_unittest.cc index f999ad4..39a1b91 100644 --- a/webkit/appcache/appcache_url_request_job_unittest.cc +++ b/webkit/appcache/appcache_url_request_job_unittest.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -401,7 +401,7 @@ class AppCacheURLRequestJobTest : public testing::Test { EXPECT_FALSE(job->is_delivering_error_response()); EXPECT_FALSE(job->has_been_started()); EXPECT_FALSE(job->has_been_killed()); - EXPECT_EQ(GURL::EmptyGURL(), job->manifest_url()); + EXPECT_EQ(GURL(), job->manifest_url()); EXPECT_EQ(kNoCacheId, job->cache_id()); EXPECT_FALSE(job->entry().has_response_id()); diff --git a/webkit/appcache/manifest_parser_unittest.cc b/webkit/appcache/manifest_parser_unittest.cc index 45ccbdd..2820884 100644 --- a/webkit/appcache/manifest_parser_unittest.cc +++ b/webkit/appcache/manifest_parser_unittest.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -62,7 +62,7 @@ TEST(ManifestParserTest, NoManifestUrl) { const std::string kData("CACHE MANIFEST\r" "relative/tobase.com\r" "http://absolute.com/addme.com"); - const GURL kUrl = GURL::EmptyGURL(); + const GURL kUrl; EXPECT_TRUE(ParseManifest(kUrl, kData.c_str(), kData.length(), manifest)); EXPECT_TRUE(manifest.explicit_urls.empty()); EXPECT_TRUE(manifest.fallback_namespaces.empty()); diff --git a/webkit/appcache/mock_appcache_storage.cc b/webkit/appcache/mock_appcache_storage.cc index 64a66a7..3c93479 100644 --- a/webkit/appcache/mock_appcache_storage.cc +++ b/webkit/appcache/mock_appcache_storage.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -335,8 +335,7 @@ void MockAppCacheStorage::ProcessFindResponseForMainRequest( // Didn't find anything. delegate_ref->delegate->OnMainResponseFound( - url, AppCacheEntry(), AppCacheEntry(), - kNoCacheId, GURL::EmptyGURL()); + url, AppCacheEntry(), AppCacheEntry(), kNoCacheId, GURL()); } void MockAppCacheStorage::ProcessMakeGroupObsolete( diff --git a/webkit/appcache/web_application_cache_host_impl.cc b/webkit/appcache/web_application_cache_host_impl.cc index 427ec87..b6586de 100644 --- a/webkit/appcache/web_application_cache_host_impl.cc +++ b/webkit/appcache/web_application_cache_host_impl.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2009 The Chromium Authors. All rights reserved. +// Copyright (c) 2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -116,7 +116,7 @@ bool WebApplicationCacheHostImpl::selectCacheWithManifest( is_new_master_entry_ = YES; } else { is_new_master_entry_ = NO; - manifest_gurl = GURL::EmptyGURL(); + manifest_gurl = GURL(); } backend_->SelectCache(host_id_, document_url_, kNoCacheId, manifest_gurl); |