RefCounted types should not have public destructors, webkit/

BUG=123295
TEST=none


Review URL: http://codereview.chromium.org/10066044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134449 0039d316-1c4b-4281-b951-d872f2087c98

2 files changed, 7 insertions, 5 deletions

diff --git a/webkit/blob/blob_url_request_job.cc b/webkit/blob/blob_url_request_job.cc
index 65f8e08..6f8ef92 100644
--- a/webkit/blob/blob_url_request_job.cc
+++ b/webkit/blob/blob_url_request_job.cc
@@ -64,10 +64,6 @@ BlobURLRequestJob::BlobURLRequestJob(
   DCHECK(file_thread_proxy_);
 }
 
-BlobURLRequestJob::~BlobURLRequestJob() {
-  STLDeleteValues(&index_to_reader_);
-}
-
 void BlobURLRequestJob::Start() {
   // Continue asynchronously.
   MessageLoop::current()->PostTask(
@@ -151,6 +147,10 @@ void BlobURLRequestJob::SetExtraRequestHeaders(
   }
 }
 
+BlobURLRequestJob::~BlobURLRequestJob() {
+  STLDeleteValues(&index_to_reader_);
+}
+
 void BlobURLRequestJob::DidStart() {
   // We only support GET request per the spec.
   if (request()->method() != "GET") {
diff --git a/webkit/blob/blob_url_request_job.h b/webkit/blob/blob_url_request_job.h
index 1df2619..436d0a9 100644
--- a/webkit/blob/blob_url_request_job.h
+++ b/webkit/blob/blob_url_request_job.h
@@ -34,7 +34,6 @@ class BLOB_EXPORT BlobURLRequestJob : public net::URLRequestJob {
   BlobURLRequestJob(net::URLRequest* request,
                     BlobData* blob_data,
                     base::MessageLoopProxy* resolving_message_loop_proxy);
-  virtual ~BlobURLRequestJob();
 
   // net::URLRequestJob methods.
   virtual void Start() OVERRIDE;
@@ -48,6 +47,9 @@ class BLOB_EXPORT BlobURLRequestJob : public net::URLRequestJob {
   virtual void SetExtraRequestHeaders(
       const net::HttpRequestHeaders& headers) OVERRIDE;
 
+ protected:
+  virtual ~BlobURLRequestJob();
+
  private:
   typedef std::map<size_t, LocalFileReader*> IndexToReaderMap;