diff options
| author | hidehiko@chromium.org <hidehiko@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-09 14:18:19 +0000 |
|---|---|---|
| committer | hidehiko@chromium.org <hidehiko@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-07-09 14:18:19 +0000 |
| commit | dc2499213b1f2cbf78e889a81f69b5b219c625e7 (patch) | |
| tree | 7f5065ccb5f51dcb0422a1cd956353fbfdad27ed /webkit/browser | |
| parent | f4d659e5b889d88c3829a80f3677cf23bdcae6be (diff) | |
| download | chromium_src-dc2499213b1f2cbf78e889a81f69b5b219c625e7.zip chromium_src-dc2499213b1f2cbf78e889a81f69b5b219c625e7.tar.gz chromium_src-dc2499213b1f2cbf78e889a81f69b5b219c625e7.tar.bz2 | |
Allow passing null-callback to |on_close_callback| explicitly.
On most file system, |on_close_callback| would do nothing. To make it easy,
this CL allows to pass null-callback to |on_close_callback| via
OpenFileCallback.
Note that, it is already checked if the callback is null or not in
FileAPIMessageFilter::OnNotifyCloseFile(), but it wasn't in OnChannelClosing().
This CL adds the Callback::is_null() check in the method, as well as adds
comments about the null for FileSystemOperation::OpenFileCallback.
BUG=258303
TEST=Ran try-bot
Review URL: https://chromiumcodereview.appspot.com/18132021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210560 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/browser')
| -rw-r--r-- | webkit/browser/fileapi/file_system_operation.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/webkit/browser/fileapi/file_system_operation.h b/webkit/browser/fileapi/file_system_operation.h index b4e887c..0f6ef5b 100644 --- a/webkit/browser/fileapi/file_system_operation.h +++ b/webkit/browser/fileapi/file_system_operation.h @@ -69,7 +69,7 @@ class FileSystemOperation { // Used for OpenFile(). |result| is the return code of the operation. // |on_close_callback| will be called after the file is closed in the child - // process. + // process. It can be null, if no operation is needed on closing a file. typedef base::Callback< void(base::PlatformFileError result, base::PlatformFile file, |