diff options
| author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-05 07:49:19 +0000 |
|---|---|---|
| committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-05 07:49:19 +0000 |
| commit | 39834d692a6f7eab24b30a83327da45baa949bd8 (patch) | |
| tree | af05fb6e44dd17bf208bc1f3fe6e67c53227f9c9 /webkit/data/plugins | |
| parent | 4505058da821358795cb6947f133807414e4e5eb (diff) | |
| download | chromium_src-39834d692a6f7eab24b30a83327da45baa949bd8.zip chromium_src-39834d692a6f7eab24b30a83327da45baa949bd8.tar.gz chromium_src-39834d692a6f7eab24b30a83327da45baa949bd8.tar.bz2 | |
Fix Flash window in Analytics being incorrectly visible.
The bug was that we accidentally marked a plugin widget as visible if it's parent was visible, even if it was explicitly set as hidden.
BUG=8927
TEST=regression test included, also can verify that analytics doesn't display the gray rectangle per the bug
Review URL: http://codereview.chromium.org/106008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15285 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/data/plugins')
| -rw-r--r-- | webkit/data/plugins/hidden_plugin.html | 2 | ||||
| -rw-r--r-- | webkit/data/plugins/hidden_plugin_iframe.html | 14 |
2 files changed, 16 insertions, 0 deletions
diff --git a/webkit/data/plugins/hidden_plugin.html b/webkit/data/plugins/hidden_plugin.html new file mode 100644 index 0000000..db6b575 --- /dev/null +++ b/webkit/data/plugins/hidden_plugin.html @@ -0,0 +1,2 @@ +<div id='result'>FAIL</div>
+<iframe src='hidden_plugin_iframe.html'></iframe>
\ No newline at end of file diff --git a/webkit/data/plugins/hidden_plugin_iframe.html b/webkit/data/plugins/hidden_plugin_iframe.html new file mode 100644 index 0000000..ad0a994 --- /dev/null +++ b/webkit/data/plugins/hidden_plugin_iframe.html @@ -0,0 +1,14 @@ +<script>
+var gotVisible = false;
+function windowHidden() {
+ if (!gotVisible)
+ parent.document.getElementById('result').innerHTML = 'DONE';
+}
+
+function windowVisible() {
+ gotVisible = true;
+ parent.document.getElementById('result').innerHTML = 'FAIL';
+}
+
+</script>
+<embed style="visibility:hidden" id='1' type='application/vnd.npapi-test' src='foo' name='hidden_plugin'>
\ No newline at end of file |