diff options
| author | darin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-08 01:05:51 +0000 |
|---|---|---|
| committer | darin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-08 01:05:51 +0000 |
| commit | c7198dc0269527b73060c2ac5de36f8c2e9b8191 (patch) | |
| tree | c2e03dfc3615f0c41ec59ad6b7c17ecd02861a9b /webkit/data | |
| parent | 1a0869a874c494ab41811dbeaa905ce5689acb01 (diff) | |
| download | chromium_src-c7198dc0269527b73060c2ac5de36f8c2e9b8191.zip chromium_src-c7198dc0269527b73060c2ac5de36f8c2e9b8191.tar.gz chromium_src-c7198dc0269527b73060c2ac5de36f8c2e9b8191.tar.bz2 | |
It turns out that we were only "failing" the iframe-onload-remove-self-no-crash.html because of an unrelated change in how WebCore renders an element. This test really should have been using dumpAsText instead of comparing the page rendering.
R=ojan
Review URL: http://codereview.chromium.org/6573
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2986 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/data')
6 files changed, 6 insertions, 73 deletions
diff --git a/webkit/data/layout_test_results/kjs/chrome/fast/events/iframe-onload-remove-self-no-crash-expected.txt b/webkit/data/layout_test_results/kjs/chrome/fast/events/iframe-onload-remove-self-no-crash-expected.txt deleted file mode 100644 index 1aba2d6..0000000 --- a/webkit/data/layout_test_results/kjs/chrome/fast/events/iframe-onload-remove-self-no-crash-expected.txt +++ /dev/null @@ -1,24 +0,0 @@ -layer at (0,0) size 800x600 - RenderView at (0,0) size 800x600 -layer at (0,0) size 800x600 - RenderBlock {HTML} at (0,0) size 800x600 - RenderBody {BODY} at (8,8) size 784x584 - RenderText {#text} at (0,0) size 574x19 - text run at (0,0) width 574: "This tests that setting remove a child frame in onload event handler does not crash the renderer. " - RenderBR {BR} at (574,15) size 0x0 - RenderPartObject {IFRAME} at (0,20) size 304x154 [border: (2px inset #000000)] - layer at (0,0) size 300x150 - RenderView at (0,0) size 300x150 - layer at (0,0) size 300x150 - RenderBlock {HTML} at (0,0) size 300x150 - RenderBody {BODY} at (8,8) size 284x134 - RenderText {#text} at (304,159) size 4x19 - text run at (304,159) width 4: " " - RenderText {#text} at (0,0) size 0x0 - RenderText {#text} at (0,0) size 0x0 - RenderPartObject {IFRAME} at (308,20) size 304x154 [border: (2px inset #000000)] - layer at (0,0) size 300x150 - RenderView at (0,0) size 300x150 - layer at (0,0) size 300x8 - RenderBlock {HTML} at (0,0) size 300x8 - RenderBody {BODY} at (8,8) size 284x0 diff --git a/webkit/data/layout_test_results/v8/chrome/fast/events/iframe-onload-remove-self-no-crash-expected.txt b/webkit/data/layout_test_results/v8/chrome/fast/events/iframe-onload-remove-self-no-crash-expected.txt deleted file mode 100644 index 1aba2d6..0000000 --- a/webkit/data/layout_test_results/v8/chrome/fast/events/iframe-onload-remove-self-no-crash-expected.txt +++ /dev/null @@ -1,24 +0,0 @@ -layer at (0,0) size 800x600 - RenderView at (0,0) size 800x600 -layer at (0,0) size 800x600 - RenderBlock {HTML} at (0,0) size 800x600 - RenderBody {BODY} at (8,8) size 784x584 - RenderText {#text} at (0,0) size 574x19 - text run at (0,0) width 574: "This tests that setting remove a child frame in onload event handler does not crash the renderer. " - RenderBR {BR} at (574,15) size 0x0 - RenderPartObject {IFRAME} at (0,20) size 304x154 [border: (2px inset #000000)] - layer at (0,0) size 300x150 - RenderView at (0,0) size 300x150 - layer at (0,0) size 300x150 - RenderBlock {HTML} at (0,0) size 300x150 - RenderBody {BODY} at (8,8) size 284x134 - RenderText {#text} at (304,159) size 4x19 - text run at (304,159) width 4: " " - RenderText {#text} at (0,0) size 0x0 - RenderText {#text} at (0,0) size 0x0 - RenderPartObject {IFRAME} at (308,20) size 304x154 [border: (2px inset #000000)] - layer at (0,0) size 300x150 - RenderView at (0,0) size 300x150 - layer at (0,0) size 300x8 - RenderBlock {HTML} at (0,0) size 300x8 - RenderBody {BODY} at (8,8) size 284x0 diff --git a/webkit/data/layout_tests/chrome/fast/events/iframe-onload-remove-self-no-crash-expected.checksum b/webkit/data/layout_tests/chrome/fast/events/iframe-onload-remove-self-no-crash-expected.checksum deleted file mode 100644 index 07da2b2..0000000 --- a/webkit/data/layout_tests/chrome/fast/events/iframe-onload-remove-self-no-crash-expected.checksum +++ /dev/null @@ -1 +0,0 @@ -9dbd31f7751e222a0d946eb28e5e5734
\ No newline at end of file diff --git a/webkit/data/layout_tests/chrome/fast/events/iframe-onload-remove-self-no-crash-expected.png b/webkit/data/layout_tests/chrome/fast/events/iframe-onload-remove-self-no-crash-expected.png Binary files differdeleted file mode 100644 index b47afc4..0000000 --- a/webkit/data/layout_tests/chrome/fast/events/iframe-onload-remove-self-no-crash-expected.png +++ /dev/null diff --git a/webkit/data/layout_tests/chrome/fast/events/iframe-onload-remove-self-no-crash-expected.txt b/webkit/data/layout_tests/chrome/fast/events/iframe-onload-remove-self-no-crash-expected.txt index b42f0cc..90742db 100644 --- a/webkit/data/layout_tests/chrome/fast/events/iframe-onload-remove-self-no-crash-expected.txt +++ b/webkit/data/layout_tests/chrome/fast/events/iframe-onload-remove-self-no-crash-expected.txt @@ -1,24 +1,2 @@ -layer at (0,0) size 800x600 - RenderView at (0,0) size 800x600 -layer at (0,0) size 800x600 - RenderBlock {HTML} at (0,0) size 800x600 - RenderBody {BODY} at (8,8) size 784x584 - RenderText {#text} at (0,0) size 601x18 - text run at (0,0) width 601: "This tests that setting remove a child frame in onload event handler does not crash the renderer. " - RenderBR {BR} at (601,14) size 0x0 - RenderPartObject {IFRAME} at (0,18) size 304x154 [border: (2px inset #000000)] - layer at (0,0) size 300x150 - RenderView at (0,0) size 300x150 - layer at (0,0) size 300x150 - RenderBlock {HTML} at (0,0) size 300x150 - RenderBody {BODY} at (8,8) size 284x134 - RenderText {#text} at (304,158) size 4x18 - text run at (304,158) width 4: " " - RenderText {#text} at (0,0) size 0x0 - RenderText {#text} at (0,0) size 0x0 - RenderPartObject {IFRAME} at (308,18) size 304x154 [border: (2px inset #000000)] - layer at (0,0) size 300x150 - RenderView at (0,0) size 300x150 - layer at (0,0) size 300x8 - RenderBlock {HTML} at (0,0) size 300x8 - RenderBody {BODY} at (8,8) size 284x0 +This tests that setting remove a child frame in onload event handler does not crash the renderer. + diff --git a/webkit/data/layout_tests/chrome/fast/events/iframe-onload-remove-self-no-crash.html b/webkit/data/layout_tests/chrome/fast/events/iframe-onload-remove-self-no-crash.html index dd45054..fca7d11 100644 --- a/webkit/data/layout_tests/chrome/fast/events/iframe-onload-remove-self-no-crash.html +++ b/webkit/data/layout_tests/chrome/fast/events/iframe-onload-remove-self-no-crash.html @@ -1,4 +1,8 @@ <html> +<script> +if (window.layoutTestController) + layoutTestController.dumpAsText(); +</script> <script src="resources/iframe-onload-remove-self-no-crash.js"></script> <body> This tests that setting remove a child frame in onload event handler |
