diff options
| author | mark@chromium.org <mark@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-02 22:02:37 +0000 |
|---|---|---|
| committer | mark@chromium.org <mark@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-02 22:02:37 +0000 |
| commit | c692dd33c9a2686d7121045de78e7a0bdfabfe86 (patch) | |
| tree | b92ab078925edeb8881d41fbfda696bb3928a2e3 /webkit/database | |
| parent | a1e1d4907a75149ff775b5037be9f56c0d2c27bd (diff) | |
| download | chromium_src-c692dd33c9a2686d7121045de78e7a0bdfabfe86.zip chromium_src-c692dd33c9a2686d7121045de78e7a0bdfabfe86.tar.gz chromium_src-c692dd33c9a2686d7121045de78e7a0bdfabfe86.tar.bz2 | |
Eliminate unnecessary dependencies on OpenGL.framework.
I'm only making this change for the Mac because I can't test it for other
platforms right now, but as a general rule, libraries belong inside
link_settings sections, not all_dependent_settings (or both).
all_dependent_settings says that anyone that depends on a given target,
even transitively through a long chain, inherits the enclsoed settings. In
this case, chrome_exe and helper_app would inappropriately be linked against
OpenGL.framework, even though they did not need to be. It is enough for
chrome_dll to link against OpenGL.framework.
For that matter, the non-library uses of all_dependent_settings in this file
are probably wrong, too. Generally, they should be replaced with
direct_dependent_settings. Inappropriate use of all_dependent_settings
results in -Defines and -Includes leaking, and can cause problems for remote
downstream targets.
BUG=none
TEST=otool -L GC.app/Contents/MacOS/GC should not show OpenGL.framework
Review URL: http://codereview.chromium.org/1604009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43533 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/database')
0 files changed, 0 insertions, 0 deletions