diff options
author | gbillock@chromium.org <gbillock@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-18 08:26:09 +0000 |
---|---|---|
committer | gbillock@chromium.org <gbillock@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-18 08:26:09 +0000 |
commit | 955a44a7c117a4ba88451d52dbcd219dde9603dd (patch) | |
tree | b345200aec7f88c5415b2648d81bcdfb6a237be0 /webkit/database | |
parent | 8331358015ea0c569f4c7d7ffd49ad013b1bbeea (diff) | |
download | chromium_src-955a44a7c117a4ba88451d52dbcd219dde9603dd.zip chromium_src-955a44a7c117a4ba88451d52dbcd219dde9603dd.tar.gz chromium_src-955a44a7c117a4ba88451d52dbcd219dde9603dd.tar.bz2 |
More SQL statement usage regularization. Back-touch some
already-edited files to standardize usage.
R=shess@chromium.org
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/9365030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122692 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/database')
-rw-r--r-- | webkit/database/databases_table.cc | 4 | ||||
-rw-r--r-- | webkit/database/quota_table.cc | 2 |
2 files changed, 4 insertions, 2 deletions
diff --git a/webkit/database/databases_table.cc b/webkit/database/databases_table.cc index 765be53..ed4b6ee 100644 --- a/webkit/database/databases_table.cc +++ b/webkit/database/databases_table.cc @@ -80,6 +80,7 @@ bool DatabasesTable::InsertDatabaseDetails(const DatabaseDetails& details) { insert_statement.BindString16(1, details.database_name); insert_statement.BindString16(2, details.description); insert_statement.BindInt64(3, details.estimated_size); + return insert_statement.Run(); } @@ -91,6 +92,7 @@ bool DatabasesTable::UpdateDatabaseDetails(const DatabaseDetails& details) { update_statement.BindInt64(1, details.estimated_size); update_statement.BindString16(2, details.origin_identifier); update_statement.BindString16(3, details.database_name); + return (update_statement.Run() && db_->GetLastChangeCount()); } @@ -100,6 +102,7 @@ bool DatabasesTable::DeleteDatabaseDetails(const string16& origin_identifier, SQL_FROM_HERE, "DELETE FROM Databases WHERE origin = ? AND name = ?")); delete_statement.BindString16(0, origin_identifier); delete_statement.BindString16(1, database_name); + return (delete_statement.Run() && db_->GetLastChangeCount()); } @@ -137,6 +140,7 @@ bool DatabasesTable::DeleteOrigin(const string16& origin_identifier) { sql::Statement delete_statement(db_->GetCachedStatement( SQL_FROM_HERE, "DELETE FROM Databases WHERE origin = ?")); delete_statement.BindString16(0, origin_identifier); + return (delete_statement.Run() && db_->GetLastChangeCount()); } diff --git a/webkit/database/quota_table.cc b/webkit/database/quota_table.cc index 2845b08..9f49200 100644 --- a/webkit/database/quota_table.cc +++ b/webkit/database/quota_table.cc @@ -25,7 +25,6 @@ int64 QuotaTable::GetOriginQuota(const string16& origin_identifier) { sql::Statement statement(db_->GetCachedStatement( SQL_FROM_HERE, "SELECT quota FROM Quota WHERE origin = ?")); statement.BindString16(0, origin_identifier); - if (statement.Step()) { return statement.ColumnInt64(0); } @@ -42,7 +41,6 @@ bool QuotaTable::SetOriginQuota(const string16& origin_identifier, SQL_FROM_HERE, "REPLACE INTO Quota VALUES (?, ?)")); replace_statement.BindString16(0, origin_identifier); replace_statement.BindInt64(1, quota); - return replace_statement.Run(); } |