diff options
| author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-01 00:43:21 +0000 |
|---|---|---|
| committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-01 00:43:21 +0000 |
| commit | 92899e21866e90a17e365704ed310b5641423a1e (patch) | |
| tree | 06b2b2e881933260e2993134af6b3e21ef20ea48 /webkit/default_plugin/plugin_impl_win.h | |
| parent | 1e59d767e37888d61dbee21a3ef6d52409e21ea5 (diff) | |
| download | chromium_src-92899e21866e90a17e365704ed310b5641423a1e.zip chromium_src-92899e21866e90a17e365704ed310b5641423a1e.tar.gz chromium_src-92899e21866e90a17e365704ed310b5641423a1e.tar.bz2 | |
Fix two issues with the plugin installer.
The first is that we weren't reloading the pages with plugins.
The second is that there was a InstallerDialog instance per plugin object on the page. On a page like nytimes.com that creates and destroys a Flash object on loading, this meant that if the user clicked on the plugin/infobar inbetween, the dialog would show up and then get hidden abruptly.
TEST=go to nytimes.com on a machine without Flash installed and click the infobar as soon as it shows up.
BUG=20690
Review URL: http://codereview.chromium.org/179051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24995 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/default_plugin/plugin_impl_win.h')
| -rw-r--r-- | webkit/default_plugin/plugin_impl_win.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/webkit/default_plugin/plugin_impl_win.h b/webkit/default_plugin/plugin_impl_win.h index a0e5596..1a1e123 100644 --- a/webkit/default_plugin/plugin_impl_win.h +++ b/webkit/default_plugin/plugin_impl_win.h @@ -187,7 +187,7 @@ class PluginInstallerImpl : public base::WindowImpl { // Returns whether or not the UI layout is right-to-left (such as Hebrew or // Arabic). - bool IsRTLLayout() const; + static bool IsRTLLayout(); // Parses the plugin instantiation arguments. This includes checking for // whether this is an activex install and reading the appropriate @@ -348,7 +348,7 @@ class PluginInstallerImpl : public base::WindowImpl { // The current state of the plugin installer. PluginInstallerState plugin_installer_state_; // Used to display the UI for plugin installation. - PluginInstallDialog install_dialog_; + PluginInstallDialog* install_dialog_; // To enable auto refresh of the plugin window once the installation // is complete, we spawn the installation process in a job, and monitor // IO completion events on the job. When the active process count of the |