diff options
author | xji@chromium.org <xji@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-24 21:32:14 +0000 |
---|---|---|
committer | xji@chromium.org <xji@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-24 21:32:14 +0000 |
commit | 6c73dd61bc320f9f2df7ade207d3aed1d99c8d81 (patch) | |
tree | cc4c1033fed45f056b276cc933392f76d70ebb54 /webkit/extensions/v8 | |
parent | d09660fada816968f0a89fd6b1fcc7674e680a16 (diff) | |
download | chromium_src-6c73dd61bc320f9f2df7ade207d3aed1d99c8d81.zip chromium_src-6c73dd61bc320f9f2df7ade207d3aed1d99c8d81.tar.gz chromium_src-6c73dd61bc320f9f2df7ade207d3aed1d99c8d81.tar.bz2 |
This CL fixes issue 43800 - RTL/LTR eliding in Linux omnibox dropdown.
Unlike Windows, in Linux, we do not draw the strings in autocomplete popup by ourselves. Instead, we rely on Pango to draw the strings. We only need to pass the text, the attribute, and the width to Pango, and Pango will draw the text correctly (taking care of visual runs for bidi text).
The only small problems are that:
when the UI is RTL, for pure English text, we need to insert LRE mark so that the ending punctuation is drawn correctly as is (not flipped), for example "....(choose location)" will not be drawn as "(....(choose location" in RTL UI.
Also, for some (not all) pure English text, when eliding, the ellipsis appears at the very left of the string in RTL UI. I do not know the reason of such inconsistency, but looks like adding LRE mark to pure English also forces the ellipsis appears at the right of the string.
BUG=43800
TEST=Omnibox should elide long URLs, mixed LTR/RTL text, etc. correctly in both LTR and RTL locales
Review URL: http://codereview.chromium.org/2824027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50773 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/extensions/v8')
0 files changed, 0 insertions, 0 deletions