diff options
author | rsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-04-28 07:04:36 +0000 |
---|---|---|
committer | rsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-04-28 07:04:36 +0000 |
commit | e0ffc6f888aff5ee5d95c5049f182aaa27105b82 (patch) | |
tree | 497a28909a6fca306b48d0e548c1b7dcd41d689a /webkit/fileapi/file_system_operation_unittest.cc | |
parent | 49dd0c40f7201e621f0bbf2d958e180fdeb57422 (diff) | |
download | chromium_src-e0ffc6f888aff5ee5d95c5049f182aaa27105b82.zip chromium_src-e0ffc6f888aff5ee5d95c5049f182aaa27105b82.tar.gz chromium_src-e0ffc6f888aff5ee5d95c5049f182aaa27105b82.tar.bz2 |
RefCounted types should not have public destructors, webkit/
BUG=123295
TEST=none
Review URL: http://codereview.chromium.org/10066044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134449 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/fileapi/file_system_operation_unittest.cc')
-rw-r--r-- | webkit/fileapi/file_system_operation_unittest.cc | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/webkit/fileapi/file_system_operation_unittest.cc b/webkit/fileapi/file_system_operation_unittest.cc index 20bf577..9eabd5e 100644 --- a/webkit/fileapi/file_system_operation_unittest.cc +++ b/webkit/fileapi/file_system_operation_unittest.cc @@ -62,8 +62,12 @@ class MockQuotaManager : public QuotaManager { callback.Run(quota::kQuotaStatusOk, usage_, quota_); } + protected: + virtual ~MockQuotaManager() {} + private: friend class MockQuotaManagerProxy; + void SetQuota(const GURL& origin, StorageType type, int64 quota) { EXPECT_EQ(origin_, origin); EXPECT_EQ(type_, type); @@ -97,10 +101,6 @@ class MockQuotaManagerProxy : public QuotaManagerProxy { registered_client_(NULL) { } - virtual ~MockQuotaManagerProxy() { - EXPECT_FALSE(registered_client_); - } - virtual void RegisterClient(QuotaClient* client) OVERRIDE { EXPECT_FALSE(registered_client_); registered_client_ = client; @@ -140,10 +140,16 @@ class MockQuotaManagerProxy : public QuotaManagerProxy { mock_manager()->SetQuota(origin, type, quota); } + protected: + virtual ~MockQuotaManagerProxy() { + EXPECT_FALSE(registered_client_); + } + private: MockQuotaManager* mock_manager() const { return static_cast<MockQuotaManager*>(quota_manager()); } + QuotaClient* registered_client_; }; |