diff options
| author | kinuko@chromium.org <kinuko@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-26 11:53:50 +0000 |
|---|---|---|
| committer | kinuko@chromium.org <kinuko@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-26 11:53:50 +0000 |
| commit | 08f8feb39b2c8801dd39a1531fb5958644162e6d (patch) | |
| tree | 8353404b39167b55fde8adb6c3d0b24b4fccdfee /webkit/fileapi/file_system_operation_unittest.cc | |
| parent | f516f4e5d8eff9285234cf18a62108d18229367c (diff) | |
| download | chromium_src-08f8feb39b2c8801dd39a1531fb5958644162e6d.zip chromium_src-08f8feb39b2c8801dd39a1531fb5958644162e6d.tar.gz chromium_src-08f8feb39b2c8801dd39a1531fb5958644162e6d.tar.bz2 | |
Move src/dest info out of FileSystemOperationContext
Current FileSystemOperationContext has both src and dest path file info in it but this is making the code for cross-FileUtil operations way complex.
This patch removes src/dest information from FileSystemOperationContext and instead:
- introduce new FileSystemPath class, which represents a file path information in a filesystem
- replace all the FilePath args in FileSystemFileUtil with FileSystemPath
The resulting code still has some ugly part, and if we get rid of cross-FU operations from each FU code eventually we may end up converting FileSystemPath back to FilePath, but I think this change is not far from the way we want to go.
BUG=114732, 110121
TEST=existing tests
Review URL: http://codereview.chromium.org/9413009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123689 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/fileapi/file_system_operation_unittest.cc')
| -rw-r--r-- | webkit/fileapi/file_system_operation_unittest.cc | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/webkit/fileapi/file_system_operation_unittest.cc b/webkit/fileapi/file_system_operation_unittest.cc index b8b86c4..15f0d2b 100644 --- a/webkit/fileapi/file_system_operation_unittest.cc +++ b/webkit/fileapi/file_system_operation_unittest.cc @@ -149,8 +149,7 @@ FilePath ASCIIToFilePath(const std::string& str) { } // namespace (anonymous) -// Test class for FileSystemOperation. Note that this just tests low-level -// operations but doesn't test OpenFileSystem. +// Test class for FileSystemOperation. class FileSystemOperationTest : public testing::Test, public base::SupportsWeakPtr<FileSystemOperationTest> { |