More filesystem cleanup: convert URL-encoded-as-FilePath to actual URL, where

possible without WebKit API changes. The WebKit changes will happen in another 
CL. 

This is a resubmit of http://codereview.chromium.org/6767010/ [third try lucky,
fourth try persistent?], which bounced most recently due to bugs manifesting
only on XP. There are a few changes here that weren't there [in
file_system_operation_write_unittest.cc and file_system_operation.cc], but
they're pretty trivial build/test fixes.

BUG=none 
TEST=none
Review URL: http://codereview.chromium.org/6821065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81319 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 17 insertions, 7 deletions

diff --git a/webkit/fileapi/file_system_operation_write_unittest.cc b/webkit/fileapi/file_system_operation_write_unittest.cc
index e331338..a678b0a 100644
--- a/webkit/fileapi/file_system_operation_write_unittest.cc
+++ b/webkit/fileapi/file_system_operation_write_unittest.cc
@@ -10,7 +10,6 @@
 
 #include "webkit/fileapi/file_system_operation.h"
 
-#include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_temp_dir.h"
@@ -81,6 +80,16 @@ class FileSystemOperationTest : public testing::Test {
   virtual void TearDown();
 
  protected:
+  GURL URLForRelativePath(const std::string& path) const {
+    // Only the path will actually get used.
+    return GURL("file://").Resolve(file_.value()).Resolve(path);
+  }
+
+  GURL URLForPath(const FilePath& path) const {
+    // Only the path will actually get used.
+    return GURL("file://").Resolve(path.value());
+  }
+
   MessageLoop loop_;
 
   ScopedTempDir dir_;
@@ -119,7 +128,7 @@ class MockDispatcher : public FileSystemCallbackDispatcher {
     ADD_FAILURE();
   }
 
-  virtual void DidOpenFileSystem(const std::string&, const FilePath&) {
+  virtual void DidOpenFileSystem(const std::string&, const GURL&) {
     ADD_FAILURE();
   }
 
@@ -165,7 +174,7 @@ TEST_F(FileSystemOperationTest, TestWriteSuccess) {
   url_request_context->blob_storage_controller()->
       RegisterBlobUrl(blob_url, blob_data);
 
-  operation()->Write(url_request_context, file_, blob_url, 0);
+  operation()->Write(url_request_context, URLForPath(file_), blob_url, 0);
   MessageLoop::current()->Run();
 
   url_request_context->blob_storage_controller()->UnregisterBlobUrl(blob_url);
@@ -185,7 +194,7 @@ TEST_F(FileSystemOperationTest, TestWriteZero) {
   url_request_context->blob_storage_controller()->
       RegisterBlobUrl(blob_url, blob_data);
 
-  operation()->Write(url_request_context, file_, blob_url, 0);
+  operation()->Write(url_request_context, URLForPath(file_), blob_url, 0);
   MessageLoop::current()->Run();
 
   url_request_context->blob_storage_controller()->UnregisterBlobUrl(blob_url);
@@ -199,7 +208,8 @@ TEST_F(FileSystemOperationTest, TestWriteInvalidBlobUrl) {
   scoped_refptr<TestURLRequestContext> url_request_context(
       new TestURLRequestContext());
 
-  operation()->Write(url_request_context, file_, GURL("blob:invalid"), 0);
+  operation()->Write(url_request_context, URLForPath(file_),
+      GURL("blob:invalid"), 0);
   MessageLoop::current()->Run();
 
   EXPECT_EQ(0, bytes_written());
@@ -218,7 +228,7 @@ TEST_F(FileSystemOperationTest, TestWriteInvalidFile) {
       RegisterBlobUrl(blob_url, blob_data);
 
   operation()->Write(url_request_context,
-                     FilePath(FILE_PATH_LITERAL("/nonexist")), blob_url, 0);
+                     URLForRelativePath("nonexist"), blob_url, 0);
   MessageLoop::current()->Run();
 
   url_request_context->blob_storage_controller()->UnregisterBlobUrl(blob_url);
@@ -238,7 +248,7 @@ TEST_F(FileSystemOperationTest, TestWriteDir) {
   url_request_context->blob_storage_controller()->
       RegisterBlobUrl(blob_url, blob_data);
 
-  operation()->Write(url_request_context, dir_.path(), blob_url, 0);
+  operation()->Write(url_request_context, URLForPath(dir_.path()), blob_url, 0);
   MessageLoop::current()->Run();
 
   url_request_context->blob_storage_controller()->UnregisterBlobUrl(blob_url);