summaryrefslogtreecommitdiffstats
path: root/webkit/fileapi/file_system_util_unittest.cc
diff options
context:
space:
mode:
authorthakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-04-12 22:10:23 +0000
committerthakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-04-12 22:10:23 +0000
commitcda3f562a282c8adab5adbb16a90ad9532b8d021 (patch)
tree11140eca636e129f8b21f56fd9504ff33f2ec458 /webkit/fileapi/file_system_util_unittest.cc
parent492db2c2a256a33a3ca66a76054711755eae014e (diff)
downloadchromium_src-cda3f562a282c8adab5adbb16a90ad9532b8d021.zip
chromium_src-cda3f562a282c8adab5adbb16a90ad9532b8d021.tar.gz
chromium_src-cda3f562a282c8adab5adbb16a90ad9532b8d021.tar.bz2
Revert 81308 (broke 10.5)- Mac: Let chrome coexist with the Chinese Handwriting IME.The renderer sandbox breaks the Chinese Handwriting shortcut while Chromeis running, even when Chrome is not active: In a nutshell, Carbon tries to loadthe IME in every process, and if that fails, it uninstalls the toggle shorcut. Itfails in the renderer process due to the sandbox. See the bug for details.Prewarming (patch set 1) doesn't work because that opens up clipboardaccess to the renderer – the IME doesn't load correctly if it doesn't haveclipboard access.dyld __interpose based interposing (patch set 2) doesn't work becauseTISCreateInputSourceList and its broken caller are in the sameframework (HIToolbox).Hence, use binary rewriting to return an arbitrary array with size > 0 to makeHIToolbox believe that the IME loads correctly, so that it doesn't uninstall theglobal handwriting keyboard shortcut.BUG=31225TEST=Enable Chinese in the input menu. Make sure Chrome's not running.Note that ctrl-shift-space opens and dismisses the Handwriting IME(you need a multitouch trackpad for that). Open Chrome, note that theIME still works.(If you run Chrome without this patch, the IME will be broken until you do ps aux | grep Chineseand then kill $CHINESE_HANDWRITING_PIDand then toggle the IME once through the Menu Extra menu.)It is a good idea to have a Terminal open during testing, because killingthe task is the only way to dismiss the IME with the keyboard without thisCL.Review URL: http://codereview.chromium.org/6801056
TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/6839001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81318 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/fileapi/file_system_util_unittest.cc')
0 files changed, 0 insertions, 0 deletions