diff options
| author | kinuko@chromium.org <kinuko@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-28 05:10:51 +0000 |
|---|---|---|
| committer | kinuko@chromium.org <kinuko@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-28 05:10:51 +0000 |
| commit | 92b8088025c2422469d759fba48db7f7f1582b7d (patch) | |
| tree | 269887396437e4b64a08f08759abce0e5d492c50 /webkit/fileapi/local_file_system_operation_unittest.cc | |
| parent | 5ce8a32ef987a3150d34c9caa9a2b47d480d49f2 (diff) | |
| download | chromium_src-92b8088025c2422469d759fba48db7f7f1582b7d.zip chromium_src-92b8088025c2422469d759fba48db7f7f1582b7d.tar.gz chromium_src-92b8088025c2422469d759fba48db7f7f1582b7d.tar.bz2 | |
2nd try: FileAPI: Split recursive remove into multiple tasks.
Original review page: https://codereview.chromium.org/12018017/
While this change makes each recursive delete run slower, concurrent jobs can run without waiting for the entire recursive job to finish.
Recursive remove end-to-end (200 files, 120 dirs, 4-level tree, total 100MB):
Before this change: Ave: 72.94 msec, Stddev: 3.571 msec
After this change: Ave:129.54 msec, Stddev: 25.368 msec
It takes 1.76 times slower than before by average (we can probably do more optimization as this implementation doesn't care much about it), while another concurrent file task called immediately after the delete could finish in 1-5 msec (while back then it needed to wait for 70-80 msec).
BUG=146215
TEST=content_unittests:.*File.*,content_browsertests:FileSystemLayoutTests.OpRemove
Review URL: https://chromiumcodereview.appspot.com/12051055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179102 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/fileapi/local_file_system_operation_unittest.cc')
| -rw-r--r-- | webkit/fileapi/local_file_system_operation_unittest.cc | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/webkit/fileapi/local_file_system_operation_unittest.cc b/webkit/fileapi/local_file_system_operation_unittest.cc index 604f91d..d170b7c 100644 --- a/webkit/fileapi/local_file_system_operation_unittest.cc +++ b/webkit/fileapi/local_file_system_operation_unittest.cc @@ -1046,9 +1046,6 @@ TEST_F(LocalFileSystemOperationTest, TestRemoveSuccess) { EXPECT_EQ(base::PLATFORM_FILE_OK, status()); EXPECT_FALSE(DirectoryExists(parent_dir_path)); - // Remove is not a 'read' access. - EXPECT_EQ(0, quota_manager_proxy()->notify_storage_accessed_count()); - EXPECT_EQ(2, change_observer()->get_and_reset_remove_directory_count()); EXPECT_EQ(1, change_observer()->get_and_reset_remove_file_count()); EXPECT_TRUE(change_observer()->HasNoChange()); |