diff options
author | darin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-15 17:21:10 +0000 |
---|---|---|
committer | darin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-15 17:21:10 +0000 |
commit | daa8c58ee49795d292312bbf217999c93693919c (patch) | |
tree | 561a327f148d74b0522871f15103e25a27b841f5 /webkit/glue/autofill_form.h | |
parent | 0b97342d07fd3ef047432b52809d31d10432ee85 (diff) | |
download | chromium_src-daa8c58ee49795d292312bbf217999c93693919c.zip chromium_src-daa8c58ee49795d292312bbf217999c93693919c.tar.gz chromium_src-daa8c58ee49795d292312bbf217999c93693919c.tar.bz2 |
Extract form related classes from the guts of WebFrameImpl.
Instead of having WebFrameImpl generate SearchableFormData, PasswordForm, and AutofillForm classes, allow the embedder (RenderView) to do so.
This is done to help minimize the dependencies WebFrameImpl has on other code, which will make it easier to move WebFrame and WebDataSource into the WebKit API.
Most significant change: Now, RenderView always sets a NavigationState on WebDataSource instances. We used to only do so for browser initiated navigations. This is done so that we can store things like SearchableFormData and friends on the NavigationState.
To facilitate this change, it was necessary to add a way through the WebKit API to refer to a HTMLFormElement. This CL introduces WebForm, which is like a RefPtr<HTMLFormElement>, so you can just copy a WebForm around by value and the right thing happens.
Some of the other changes are about moving more things into the webkit_glue namespace. On hindsight, I probably should have done that as a separate CL.
BUG=10041
TEST=none
R=brettw
Review URL: http://codereview.chromium.org/126083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18395 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/glue/autofill_form.h')
-rw-r--r-- | webkit/glue/autofill_form.h | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/webkit/glue/autofill_form.h b/webkit/glue/autofill_form.h index 8375e75..4cf1b20 100644 --- a/webkit/glue/autofill_form.h +++ b/webkit/glue/autofill_form.h @@ -9,13 +9,17 @@ #include <vector> namespace WebCore { - class HTMLInputElement; - class HTMLFormElement; +class HTMLInputElement; } +namespace WebKit { +class WebForm; +} + +namespace webkit_glue { + // The AutofillForm struct represents a single HTML form together with the // values entered in the fields. - class AutofillForm { public: // Struct for storing name/value pairs. @@ -29,7 +33,7 @@ class AutofillForm { std::wstring value; }; - static AutofillForm* CreateAutofillForm(WebCore::HTMLFormElement* form); + static AutofillForm* Create(const WebKit::WebForm& form); // Returns the name that should be used for the specified |element| when // storing autofill data. This is either the field name or its id, an empty @@ -41,4 +45,6 @@ class AutofillForm { std::vector<Element> elements; }; +} // namespace webkit_glue + #endif // WEBKIT_GLUE_AUTOFILL_FORM_H_ |