Fix for spell check underlines disappearing when user clicks out of the Text Box. WebKit removes all spell check markers in Frame::respondToChangedSelection() if, for a text box, the ShouldSpellcheckByDefault() method we have defined in the glue returns false. The problem is, ShouldSpellcheckByDefault() is also called just after the user clicks outside the textbox. As a result, it either detects that the text box is not a focussed node, or determines that the editor is not editable, and returns false, which makes the Frame remove all the markers from the corresponding document object.

BUG=www.crbug.com/6058
TEST=Write random stuff in a text box - after the underlines appear, click outside the text box - the underlines should not disappear. Other functionalities of spellcheck, such as changing spell check language, toggling spell check language on/off, should not be affected at all.
Review URL: http://codereview.chromium.org/159516

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21892 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 8 insertions, 2 deletions

diff --git a/webkit/glue/editor_client_impl.cc b/webkit/glue/editor_client_impl.cc
index bd88c92..6fe6a73 100644
--- a/webkit/glue/editor_client_impl.cc
+++ b/webkit/glue/editor_client_impl.cc
@@ -130,13 +130,19 @@ bool EditorClientImpl::ShouldSpellcheckByDefault() {
   if (!document)
     return false;
   const WebCore::Node* node = document->focusedNode();
+  // If |node| is NULL, we default to allowing spellchecking. This is done in
+  // order to mitigate the issue when the user clicks outside the textbox, as a
+  // result of which |node| becomes NULL, resulting in all the spell check
+  // markers being deleted. Also, the Frame will decide not to do spellchecking
+  // if the user can't edit - so returning true here will not cause any problems
+  // to the Frame's behavior.
   if (!node)
-    return false;
+    return true;
   const WebCore::RenderObject* renderer = node->renderer();
   if (!renderer)
     return false;
 
-  return (!renderer->isTextField() && editor->canEdit());
+  return !renderer->isTextField();
 }
 
 bool EditorClientImpl::isContinuousSpellCheckingEnabled() {