diff options
| author | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-19 21:56:18 +0000 |
|---|---|---|
| committer | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-19 21:56:18 +0000 |
| commit | dd1b4959032fd4684534ff07dab83f71391b36aa (patch) | |
| tree | fe904cf6a90dcb7a1e3795fe3c203b86f2fdca0f /webkit/glue/form_field.h | |
| parent | de49ea10c04eb354ab0187b8f98898c272660037 (diff) | |
| download | chromium_src-dd1b4959032fd4684534ff07dab83f71391b36aa.zip chromium_src-dd1b4959032fd4684534ff07dab83f71391b36aa.tar.gz chromium_src-dd1b4959032fd4684534ff07dab83f71391b36aa.tar.bz2 | |
AutoFill fill billing address when credit card settings specify a billing address.
Fixes address type matching in |AddressField::AddressTypeFromText| method. Also, extends |AutoFillManager::FillAutoFillFormData| method to fill associated billing address when filling a credit card that has billing information set in preferences. Adds new unit test AutoFillManagerTest.FillCreditCardFormWithBilling and fixes others.
BUG=44227
TEST=AddressFieldTest.ParseOneLineAddress, \
AddressFieldTest.ParseOneLineAddressBilling, \
AddressFieldTest.ParseOneLineAddressShipping, \
AutoFillManagerTest.FillCreditCardForm, \
AutoFillManagerTest.FillCreditCardFormWithBilling, \
FormStructureTest.HeuristicsSample8, \
and manual test with everything2.html bug file.
Review URL: http://codereview.chromium.org/2078016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47731 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/glue/form_field.h')
| -rw-r--r-- | webkit/glue/form_field.h | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/webkit/glue/form_field.h b/webkit/glue/form_field.h index b0e9dec..691d2af9 100644 --- a/webkit/glue/form_field.h +++ b/webkit/glue/form_field.h @@ -35,9 +35,17 @@ class FormField { } void set_size(int size) { size_ = size; } + // Equality tests for identity which does not include |value_| or |size_|. + // Use |StrictlyEqualsHack| method to test all members. + // TODO(dhollowa): These operators need to be revised when we implement field + // ids. bool operator==(const FormField& field) const; bool operator!=(const FormField& field) const; + // Test equality of all data members. + // TODO(dhollowa): This will be removed when we implement field ids. + bool StrictlyEqualsHack(const FormField& field) const; + private: string16 label_; string16 name_; |