diff options
author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-05 23:40:45 +0000 |
---|---|---|
committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-05 23:40:45 +0000 |
commit | 122331d5cf1fdad245bb4e174c188ec3851b4d13 (patch) | |
tree | d9d47ff2304f96e0f5bbe97e080c80069ad45c9a /webkit/glue/media | |
parent | f164cea41472f9e9ec21579233e2c42a7b9d5184 (diff) | |
download | chromium_src-122331d5cf1fdad245bb4e174c188ec3851b4d13.zip chromium_src-122331d5cf1fdad245bb4e174c188ec3851b4d13.tar.gz chromium_src-122331d5cf1fdad245bb4e174c188ec3851b4d13.tar.bz2 |
Third patch in making destructors of refcounted objects private.
BUG=26749
Review URL: http://codereview.chromium.org/363023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31169 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/glue/media')
-rw-r--r-- | webkit/glue/media/buffered_data_source.h | 6 | ||||
-rw-r--r-- | webkit/glue/media/buffered_data_source_unittest.cc | 4 |
2 files changed, 8 insertions, 2 deletions
diff --git a/webkit/glue/media/buffered_data_source.h b/webkit/glue/media/buffered_data_source.h index 6a68048..bbab6d6 100644 --- a/webkit/glue/media/buffered_data_source.h +++ b/webkit/glue/media/buffered_data_source.h @@ -47,7 +47,6 @@ class BufferedResourceLoader : const GURL& url, int64 first_byte_position, int64 last_byte_position); - virtual ~BufferedResourceLoader(); // Start the resource loading with the specified URL and range. // This method operates in asynchronous mode. Once there's a response from the @@ -120,11 +119,16 @@ class BufferedResourceLoader : GURL GetURLForDebugging() const { return url_; } protected: + friend class base::RefCountedThreadSafe<BufferedResourceLoader>; + // An empty constructor so mock classes can be constructed. BufferedResourceLoader() { } + virtual ~BufferedResourceLoader(); + private: + // Defer the resource loading if the buffer is full. void EnableDeferIfNeeded(); diff --git a/webkit/glue/media/buffered_data_source_unittest.cc b/webkit/glue/media/buffered_data_source_unittest.cc index d22bcbc..f96bac1 100644 --- a/webkit/glue/media/buffered_data_source_unittest.cc +++ b/webkit/glue/media/buffered_data_source_unittest.cc @@ -377,7 +377,9 @@ class MockBufferedResourceLoader : public BufferedResourceLoader { MOCK_METHOD0(GetBufferedFirstBytePosition, int64()); MOCK_METHOD0(GetBufferedLastBytePosition, int64()); - private: + protected: + ~MockBufferedResourceLoader() {} + DISALLOW_COPY_AND_ASSIGN(MockBufferedResourceLoader); }; |