Reject invalid URLs in SimpleDataSource

Report an error when an invalid url is received.
Checks also the scheme against, ftp, http, https and file.

Review URL: http://codereview.chromium.org/131061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18754 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 18 insertions, 1 deletions

diff --git a/webkit/glue/media/simple_data_source.cc b/webkit/glue/media/simple_data_source.cc
index a9daf10..6207ddd 100644
--- a/webkit/glue/media/simple_data_source.cc
+++ b/webkit/glue/media/simple_data_source.cc
@@ -12,6 +12,22 @@
 #include "webkit/glue/resource_loader_bridge.h"
 #include "webkit/glue/webappcachecontext.h"
 
+namespace {
+
+const char kHttpScheme[] = "http";
+const char kHttpsScheme[] = "https";
+const char kFtpScheme[] = "ftp";
+
+// A helper method that accepts only HTTP, HTTPS and FILE protocol.
+bool IsSchemeSupported(const GURL& url) {
+  return url.SchemeIs(kHttpScheme) ||
+         url.SchemeIs(kHttpsScheme) ||
+         url.SchemeIs(kFtpScheme) ||
+         url.SchemeIsFile();
+}
+
+}  // namespace
+
 namespace webkit_glue {
 
 SimpleDataSource::SimpleDataSource(MessageLoop* render_loop, int32 routing_id)
@@ -44,7 +60,8 @@ bool SimpleDataSource::Initialize(const std::string& url) {
 
   // Validate the URL.
   SetURL(GURL(url));
-  if (!url_.is_valid()) {
+  if (!url_.is_valid() || !IsSchemeSupported(url_)) {
+    host_->Error(media::PIPELINE_ERROR_NETWORK);
     return false;
   }