diff options
author | ajwong@chromium.org <ajwong@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-21 20:24:58 +0000 |
---|---|---|
committer | ajwong@chromium.org <ajwong@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-21 20:24:58 +0000 |
commit | 6e8afff24ed38abebc7537d97e1735ede5ca7755 (patch) | |
tree | cfcab05a0bb7b168108744d1353722ab6ba611a5 /webkit/glue/media | |
parent | 3b50bd3a2bb00f35e208201b54a1b4d0576c94d9 (diff) | |
download | chromium_src-6e8afff24ed38abebc7537d97e1735ede5ca7755.zip chromium_src-6e8afff24ed38abebc7537d97e1735ede5ca7755.tar.gz chromium_src-6e8afff24ed38abebc7537d97e1735ede5ca7755.tar.bz2 |
Reverting r24002 due to test_shell_tests redness
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24004 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/glue/media')
-rw-r--r-- | webkit/glue/media/buffered_data_source.cc | 3 | ||||
-rw-r--r-- | webkit/glue/media/buffered_data_source_unittest.cc | 44 | ||||
-rw-r--r-- | webkit/glue/media/simple_data_source.cc | 2 |
3 files changed, 11 insertions, 38 deletions
diff --git a/webkit/glue/media/buffered_data_source.cc b/webkit/glue/media/buffered_data_source.cc index 6726885..5f739ba 100644 --- a/webkit/glue/media/buffered_data_source.cc +++ b/webkit/glue/media/buffered_data_source.cc @@ -765,9 +765,6 @@ void BufferedDataSource::InitialStartCallback(int error) { host()->SetStreaming(true); } - // Currently, only files can be used reliably w/o a network. - host()->SetLoaded(url_.SchemeIsFile()); - initial_response_received_ = true; if (probe_response_received_) DoneInitialization(); diff --git a/webkit/glue/media/buffered_data_source_unittest.cc b/webkit/glue/media/buffered_data_source_unittest.cc index 003313c..4d9efe8 100644 --- a/webkit/glue/media/buffered_data_source_unittest.cc +++ b/webkit/glue/media/buffered_data_source_unittest.cc @@ -30,15 +30,8 @@ using ::testing::WithArgs; namespace { const char* kHttpUrl = "http://test"; -const char* kFileUrl = "file://test"; const int kDataSize = 1024; -enum NetworkState { - NONE, - LOADED, - LOADING -}; - } // namespace namespace webkit_glue { @@ -407,7 +400,7 @@ class BufferedDataSourceTest : public testing::Test { } } - virtual ~BufferedDataSourceTest() { + ~BufferedDataSourceTest() { if (data_source_) { // Release the bridge factory because we don't own it. // Expects bridge factory to be destroyed along with data source. @@ -421,7 +414,7 @@ class BufferedDataSourceTest : public testing::Test { } void InitializeDataSource(const char* url, int error, int probe_error, - int64 instance_size, NetworkState networkState) { + int64 instance_size) { // Saves the url first. gurl_ = GURL(url); @@ -439,14 +432,6 @@ class BufferedDataSourceTest : public testing::Test { loader_ = new StrictMock<MockBufferedResourceLoader>(); probe_loader_ = new StrictMock<MockBufferedResourceLoader>(); - if (networkState == LOADED) { - EXPECT_CALL(host_, SetLoaded(true)); - } else if (networkState == LOADING) { - EXPECT_CALL(host_, SetLoaded(false)); - } - - // TODO(ajwong): This mock is too strict. We do not need to guarantee a - // full sequencing each of these expectations. InSequence s; StrictMock<media::MockFilterCallback> callback; @@ -463,7 +448,6 @@ class BufferedDataSourceTest : public testing::Test { .WillOnce(DoAll(Assign(&error_, error), Invoke(this, &BufferedDataSourceTest::InvokeStartCallback))); - if (error == net::OK) { EXPECT_CALL(*loader_, instance_size()) .WillOnce(Return(instance_size)); @@ -705,36 +689,36 @@ class BufferedDataSourceTest : public testing::Test { }; TEST_F(BufferedDataSourceTest, InitializationSuccess) { - InitializeDataSource(kHttpUrl, net::OK, net::OK, 1024, LOADING); + InitializeDataSource(kHttpUrl, net::OK, net::OK, 1024); StopDataSource(); } TEST_F(BufferedDataSourceTest, InitiailizationFailed) { InitializeDataSource(kHttpUrl, net::ERR_FILE_NOT_FOUND, - net::ERR_FILE_NOT_FOUND, 0, NONE); + net::ERR_FILE_NOT_FOUND, 0); StopDataSource(); } TEST_F(BufferedDataSourceTest, MissingContentLength) { - InitializeDataSource(kHttpUrl, net::OK, net::OK, -1, LOADING); + InitializeDataSource(kHttpUrl, net::OK, net::OK, -1); StopDataSource(); } TEST_F(BufferedDataSourceTest, RangeRequestNotSupported) { InitializeDataSource(kHttpUrl, net::OK, - net::ERR_REQUEST_RANGE_NOT_SATISFIABLE, 1024, LOADING); + net::ERR_REQUEST_RANGE_NOT_SATISFIABLE, 1024); StopDataSource(); } TEST_F(BufferedDataSourceTest, MissingContentLengthAndRangeRequestNotSupported) { InitializeDataSource(kHttpUrl, net::OK, - net::ERR_REQUEST_RANGE_NOT_SATISFIABLE, -1, LOADING); + net::ERR_REQUEST_RANGE_NOT_SATISFIABLE, -1); StopDataSource(); } TEST_F(BufferedDataSourceTest, ReadCacheHit) { - InitializeDataSource(kHttpUrl, net::OK, net::OK, 25, LOADING); + InitializeDataSource(kHttpUrl, net::OK, net::OK, 25); // Performs read with cache hit. ReadDataSourceHit(10, 10, 10); @@ -746,27 +730,21 @@ TEST_F(BufferedDataSourceTest, ReadCacheHit) { } TEST_F(BufferedDataSourceTest, ReadCacheMiss) { - InitializeDataSource(kHttpUrl, net::OK, net::OK, 1024, LOADING); + InitializeDataSource(kHttpUrl, net::OK, net::OK, 1024); ReadDataSourceMiss(1000, 10); ReadDataSourceMiss(20, 10); StopDataSource(); } TEST_F(BufferedDataSourceTest, ReadFailed) { - InitializeDataSource(kHttpUrl, net::OK, net::OK, 1024, LOADING); + InitializeDataSource(kHttpUrl, net::OK, net::OK, 1024); ReadDataSourceHit(10, 10, 10); ReadDataSourceFailed(10, 10, net::ERR_CONNECTION_RESET); StopDataSource(); } TEST_F(BufferedDataSourceTest, ReadTimesOut) { - InitializeDataSource(kHttpUrl, net::OK, net::OK, 1024, LOADING); - ReadDataSourceTimesOut(20, 10); - StopDataSource(); -} - -TEST_F(BufferedDataSourceTest, FileHasLoadedState) { - InitializeDataSource(kFileUrl, net::OK, net::OK, 1024, LOADED); + InitializeDataSource(kHttpUrl, net::OK, net::OK, 1024); ReadDataSourceTimesOut(20, 10); StopDataSource(); } diff --git a/webkit/glue/media/simple_data_source.cc b/webkit/glue/media/simple_data_source.cc index 52ea388..639aa5f 100644 --- a/webkit/glue/media/simple_data_source.cc +++ b/webkit/glue/media/simple_data_source.cc @@ -71,8 +71,6 @@ void SimpleDataSource::Initialize(const std::string& url, return; } - host()->SetLoaded(url_.SchemeIsFile()); - // Post a task to the render thread to start loading the resource. render_loop_->PostTask(FROM_HERE, NewRunnableMethod(this, &SimpleDataSource::StartTask)); |