diff options
author | evanm@google.com <evanm@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-27 22:46:31 +0000 |
---|---|---|
committer | evanm@google.com <evanm@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-27 22:46:31 +0000 |
commit | dca5cbb44a2665ce7248d99fae0007ed344734cf (patch) | |
tree | e77968d2f3f085d9cab529b1b68f54d4508850a0 /webkit/glue/multipart_response_delegate_unittest.cc | |
parent | 7b44dee2620540809ccda43ab3041a5908d775e1 (diff) | |
download | chromium_src-dca5cbb44a2665ce7248d99fae0007ed344734cf.zip chromium_src-dca5cbb44a2665ce7248d99fae0007ed344734cf.tar.gz chromium_src-dca5cbb44a2665ce7248d99fae0007ed344734cf.tar.bz2 |
Port a few test_shell_tests. Now it runs 45 of them.
I removed some files from test_files because scons complains (warns)
when a file is both in test_files and input_files. So the files removed from
test_files also exist in input_files and at some pointed will be ported anyway.
I also made some linking stubs.
BUG=3674
Review URL: http://codereview.chromium.org/7974
Patch from Paweł Hajdan jr <phajdan.jr@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4031 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/glue/multipart_response_delegate_unittest.cc')
-rw-r--r-- | webkit/glue/multipart_response_delegate_unittest.cc | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/webkit/glue/multipart_response_delegate_unittest.cc b/webkit/glue/multipart_response_delegate_unittest.cc index 325b8ad..93bfcb2 100644 --- a/webkit/glue/multipart_response_delegate_unittest.cc +++ b/webkit/glue/multipart_response_delegate_unittest.cc @@ -13,7 +13,6 @@ MSVC_PUSH_WARNING_LEVEL(0); #include "ResourceResponse.h" #include "ResourceHandle.h" #include "ResourceHandleClient.h" -#include "String.h" MSVC_POP_WARNING(); #include "base/basictypes.h" @@ -89,7 +88,7 @@ TEST(MultipartResponseTest, Functions) { { "Line\rLine", 4, 1 }, { "Line\r\rLine", 4, 1 }, }; - for (int i = 0; i < arraysize(line_tests); ++i) { + for (size_t i = 0; i < ARRAYSIZE_UNSAFE(line_tests); ++i) { EXPECT_EQ(line_tests[i].expected, delegate.PushOverLine(line_tests[i].input, line_tests[i].position)); @@ -111,7 +110,7 @@ TEST(MultipartResponseTest, Functions) { { "Foo: bar\r\nBaz:\n", false, 0, "Foo: bar\r\nBaz:\n" }, { "\r\n", true, 1, "" }, }; - for (int i = 0; i < arraysize(header_tests); ++i) { + for (size_t i = 0; i < ARRAYSIZE_UNSAFE(header_tests); ++i) { client.Reset(); delegate.data_.assign(header_tests[i].data); EXPECT_EQ(header_tests[i].rv, @@ -154,7 +153,7 @@ TEST(MultipartResponseTest, Functions) { { "foo", "bound", string::npos }, { "bound", "--boundbound", 0 }, }; - for (int i = 0; i < arraysize(boundary_tests); ++i) { + for (size_t i = 0; i < ARRAYSIZE_UNSAFE(boundary_tests); ++i) { delegate.boundary_.assign(boundary_tests[i].boundary); delegate.data_.assign(boundary_tests[i].data); EXPECT_EQ(boundary_tests[i].position, @@ -425,7 +424,7 @@ TEST(MultipartResponseTest, MultipartByteRangeParsingTest) { result = MultipartResponseDelegate::ReadMultipartBoundary( response3, &multipart_boundary); EXPECT_EQ(result, false); - EXPECT_EQ(multipart_boundary.length(), 0); + EXPECT_EQ(multipart_boundary.length(), 0U); } TEST(MultipartResponseTest, MultipartContentRangesTest) { |