diff options
author | scherkus@chromium.org <scherkus@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-03 01:49:16 +0000 |
---|---|---|
committer | scherkus@chromium.org <scherkus@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-03 01:49:16 +0000 |
commit | 8f2bf64884944e8b770852240e34e79f117acbb6 (patch) | |
tree | e7235339bc556dc5f933b75578cb12ca8f2ce905 /webkit/glue/multipart_response_delegate_unittest.cc | |
parent | ebc34fab52eabbb680eee966bb10e8f8a8cbd845 (diff) | |
download | chromium_src-8f2bf64884944e8b770852240e34e79f117acbb6.zip chromium_src-8f2bf64884944e8b770852240e34e79f117acbb6.tar.gz chromium_src-8f2bf64884944e8b770852240e34e79f117acbb6.tar.bz2 |
Revert 68094 - Refactoring BufferedDataSource to work with WebURLLoader instead of a MediaResourceLoaderBridge.
One thing to notice is that both buffered_data_source_unittest and simple_data_source_unittest need to have a way to inject a MockWebURLLoader into the BufferedResourceLoader and the SimpleDataSource. In order to make sure a new one is not created during a Start(), I introduced the function SetURLLoaderForTest and keep_test_loader flag.
Patch by annacc@chromium.org:
http://codereview.chromium.org/3863002/
BUG=16751
TEST=src/xcodebuild/Debug/test_shell_tests --gtest_filter=Buffered*
src/xcodebuild/Debug/test_shell_tests --gtest_filter=Simple*
src/webkit/tools/layout_tests/run_webkit_tests.sh --debug media
webkit/tools/layout_tests/run_webkit_tests.sh --debug http/tests/media
TBR=scherkus@chromium.org
Review URL: http://codereview.chromium.org/5619002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68126 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/glue/multipart_response_delegate_unittest.cc')
-rw-r--r-- | webkit/glue/multipart_response_delegate_unittest.cc | 16 |
1 files changed, 4 insertions, 12 deletions
diff --git a/webkit/glue/multipart_response_delegate_unittest.cc b/webkit/glue/multipart_response_delegate_unittest.cc index 1837cb5..fab798c 100644 --- a/webkit/glue/multipart_response_delegate_unittest.cc +++ b/webkit/glue/multipart_response_delegate_unittest.cc @@ -550,12 +550,10 @@ TEST(MultipartResponseTest, MultipartContentRangesTest) { int content_range_lower_bound = 0; int content_range_upper_bound = 0; - int content_range_instance_size = 0; bool result = MultipartResponseDelegate::ReadContentRanges( response1, &content_range_lower_bound, - &content_range_upper_bound, - &content_range_instance_size); + &content_range_upper_bound); EXPECT_EQ(result, true); EXPECT_EQ(content_range_lower_bound, 1000); @@ -569,12 +567,10 @@ TEST(MultipartResponseTest, MultipartContentRangesTest) { content_range_lower_bound = 0; content_range_upper_bound = 0; - content_range_instance_size = 0; result = MultipartResponseDelegate::ReadContentRanges( response2, &content_range_lower_bound, - &content_range_upper_bound, - &content_range_instance_size); + &content_range_upper_bound); EXPECT_EQ(result, false); @@ -586,12 +582,10 @@ TEST(MultipartResponseTest, MultipartContentRangesTest) { content_range_lower_bound = 0; content_range_upper_bound = 0; - content_range_instance_size = 0; result = MultipartResponseDelegate::ReadContentRanges( response3, &content_range_lower_bound, - &content_range_upper_bound, - &content_range_instance_size); + &content_range_upper_bound); EXPECT_EQ(result, true); EXPECT_EQ(content_range_lower_bound, 1000); @@ -604,12 +598,10 @@ TEST(MultipartResponseTest, MultipartContentRangesTest) { content_range_lower_bound = 0; content_range_upper_bound = 0; - content_range_instance_size = 0; result = MultipartResponseDelegate::ReadContentRanges( response4, &content_range_lower_bound, - &content_range_upper_bound, - &content_range_instance_size); + &content_range_upper_bound); EXPECT_EQ(result, false); } |