diff options
author | iyengar@google.com <iyengar@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-09-19 02:09:49 +0000 |
---|---|---|
committer | iyengar@google.com <iyengar@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-09-19 02:09:49 +0000 |
commit | 84f89cacc8f09a2fbc1fd82b30af13dd35624869 (patch) | |
tree | 9e60daee9caffaaaa3da96fd46b0c4ba28318fc8 /webkit/glue/plugins/plugin_instance.h | |
parent | 172300b0cd0748cade220e03dcc2b3459ee14b80 (diff) | |
download | chromium_src-84f89cacc8f09a2fbc1fd82b30af13dd35624869.zip chromium_src-84f89cacc8f09a2fbc1fd82b30af13dd35624869.tar.gz chromium_src-84f89cacc8f09a2fbc1fd82b30af13dd35624869.tar.bz2 |
This CB fixes the following issue1. http://code.google.com/p/chromium/issues/detail?id=206This is a performance issue while loading PDF documents. The fix is to support PDF fast webview, which is basically support for the NPN_RequestRead API, which allows a plugin to request specific byte ranges in HTTP GET requests. This also needs support for seekable streams. Our support for seekable streams is limited to HTTP servers which allow byte range requests. Firefox also supports a mode in which the the browser caches the file on disk for servers which don't support byte range requests. The plugin_data_stream.cc/.h files are being removed as there is not much value in their existence. The needed functionality is available in the PluginStreamUrl class, which now services manual data streams as well. Testing this is a touch tricky as we need a HTTP server which serves byte range requests. Will add those in a subsequent CB.Also fixed a bug in the multipart parser where we need to ignore leading newline characters while parsing the header.Bug=206
Review URL: http://codereview.chromium.org/2896
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2400 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/glue/plugins/plugin_instance.h')
-rw-r--r-- | webkit/glue/plugins/plugin_instance.h | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/webkit/glue/plugins/plugin_instance.h b/webkit/glue/plugins/plugin_instance.h index b37153b..b6b1465 100644 --- a/webkit/glue/plugins/plugin_instance.h +++ b/webkit/glue/plugins/plugin_instance.h @@ -192,6 +192,9 @@ class PluginInstance : public base::RefCounted<PluginInstance> { return popups_enabled_stack_.empty() ? false : popups_enabled_stack_.top(); } + // Initiates byte range reads for plugins. + void RequestRead(NPStream* stream, NPByteRange* range_list); + private: void OnPluginThreadAsyncCall(void (*func)(void *), void *userData); @@ -238,7 +241,7 @@ class PluginInstance : public base::RefCounted<PluginInstance> { // (MozillaExtensionApi) created as a result of NPN_GetValue // in the context of NP_Initialize. static ThreadLocalStorage::Slot plugin_instance_tls_index_; - scoped_refptr<PluginDataStream> plugin_data_stream_; + scoped_refptr<PluginStreamUrl> plugin_data_stream_; GURL instance_url_; // This flag if true indicates that the plugin data would be passed from |