diff options
| author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-11 21:01:17 +0000 |
|---|---|---|
| committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-11 21:01:17 +0000 |
| commit | 91332b626ed0625764b76ec108f5de24ea7c22ed (patch) | |
| tree | 5d6d40632c7b4de720ae3dd96431caf27d17aba5 /webkit/glue/plugins/test/plugin_geturl_test.h | |
| parent | 02473008f5f1948494b9fb69e5781746b66f6f80 (diff) | |
| download | chromium_src-91332b626ed0625764b76ec108f5de24ea7c22ed.zip chromium_src-91332b626ed0625764b76ec108f5de24ea7c22ed.tar.gz chromium_src-91332b626ed0625764b76ec108f5de24ea7c22ed.tar.bz2 | |
Fixes a crash in the plugin process specifically in the PluginStreamUrl::DidReceiveData
function. This crash occurs if the PluginStreamUrl instance is deleted in the context of
PluginStream::Write which occurs if the underlying NPP_Write call to the plugin returns
a negative value, indicating that the plugin did not accept data. We close the stream in
this case which releases existing references to the PluginStream which results in the object
being deleted.
Added a UI test for this case.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=19393
Bug=19393
Review URL: http://codereview.chromium.org/199093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26011 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/glue/plugins/test/plugin_geturl_test.h')
| -rw-r--r-- | webkit/glue/plugins/test/plugin_geturl_test.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/webkit/glue/plugins/test/plugin_geturl_test.h b/webkit/glue/plugins/test/plugin_geturl_test.h index 1ff443b..6372ef9 100644 --- a/webkit/glue/plugins/test/plugin_geturl_test.h +++ b/webkit/glue/plugins/test/plugin_geturl_test.h @@ -46,6 +46,7 @@ class PluginGetURLTest : public PluginTest { // This flag is set to true in the context of the NPN_Evaluate call. bool npn_evaluate_context_; std::string page_not_found_url_; + std::string fail_write_url_; }; } // namespace NPAPIClient |