diff options
| author | yurys@google.com <yurys@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-02 18:45:07 +0000 |
|---|---|---|
| committer | yurys@google.com <yurys@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-02 18:45:07 +0000 |
| commit | 5ce1080087f15aba535651d45fedd456992641cf (patch) | |
| tree | e30e61c97782267077cc26a4a0939a2fbc66bdc1 /webkit/glue/resource_fetcher.cc | |
| parent | 1a33ee397f360ee793dee7faf618ac8093f768d1 (diff) | |
| download | chromium_src-5ce1080087f15aba535651d45fedd456992641cf.zip chromium_src-5ce1080087f15aba535651d45fedd456992641cf.tar.gz chromium_src-5ce1080087f15aba535651d45fedd456992641cf.tar.bz2 | |
DevTools: report correct content length for resources.
Currently lengthReceived always has the same value as dataLength when Safari calls ResourceHandle::didReceiveData. In Chrome expected content length is passed as lengthReceived parameter which leads to incorrect content length to be stored in InspectorResource. InspectorResource expects lengthReceived to be the length of current data chunk(see InspectorResource::addLength). So I changed lengthReceived parameter to be dataLength.
Darin, I see your TODO comment at line 581 in http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/weburlloader_impl.cc?annotate=6296 (the comment was deleted later) so I think you are right person to review the change in weburlloader_impl.cc. Please look at weburlloader_impl.cc and feel free to leave devtools specific changes to Alex and Pavel.
BUG=25213
TEST=DevToolsSanityTest.TestResourceContentLength
Review URL: http://codereview.chromium.org/295041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30725 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/glue/resource_fetcher.cc')
| -rw-r--r-- | webkit/glue/resource_fetcher.cc | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/webkit/glue/resource_fetcher.cc b/webkit/glue/resource_fetcher.cc index 06bfd09..ccd007f 100644 --- a/webkit/glue/resource_fetcher.cc +++ b/webkit/glue/resource_fetcher.cc @@ -73,8 +73,7 @@ void ResourceFetcher::didReceiveResponse( } void ResourceFetcher::didReceiveData( - WebURLLoader* loader, const char* data, int data_length, - long long total_data_length) { + WebURLLoader* loader, const char* data, int data_length) { DCHECK(!completed_); DCHECK(data_length > 0); |