diff options
| author | tonyg@chromium.org <tonyg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-28 15:37:17 +0000 |
|---|---|---|
| committer | tonyg@chromium.org <tonyg@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-28 15:37:17 +0000 |
| commit | 471b040aea1fb982b1701e36529af509e816dc21 (patch) | |
| tree | 61a23be76dc4323efb357133e26a943a4ec75ef4 /webkit/glue/resource_loader_bridge.h | |
| parent | 18d59bf78fef12541ef38b405f6c8d3582e9b8fd (diff) | |
| download | chromium_src-471b040aea1fb982b1701e36529af509e816dc21.zip chromium_src-471b040aea1fb982b1701e36529af509e816dc21.tar.gz chromium_src-471b040aea1fb982b1701e36529af509e816dc21.tar.bz2 | |
Fix bug which caused DNS time not to be reported by LoadTimingObserver.
The problem was the LogBoundConnectJobToRequest() sets
SOCKET_POOL_BOUND_TO_CONNECT_JOB after RemoveConnectJob() ends
SOCKET_POOL_CONNECT_JOB. Since there is no chance to return to the event loop,
it is safe (although fragile), to store the last connect job record and access
that on SOCKET_POOL_BOUND_TO_CONNECT_JOB.
Also, after fixing the DNS issue, it became apparent that what was being
measured as connect time actually included more than just the TCP connect. So I
fixed that as well.
BUG=50229
TEST=LoadTimingObserverTest.*
Review URL: http://codereview.chromium.org/3028026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53945 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/glue/resource_loader_bridge.h')
| -rw-r--r-- | webkit/glue/resource_loader_bridge.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/webkit/glue/resource_loader_bridge.h b/webkit/glue/resource_loader_bridge.h index 7d85bd3..e4d439f 100644 --- a/webkit/glue/resource_loader_bridge.h +++ b/webkit/glue/resource_loader_bridge.h @@ -117,12 +117,12 @@ class ResourceLoaderBridge { // The time that DNS lookup ended. For reused sockets this time is -1. int32 dns_end; - // The time that establishing connection started. For reused sockets - // this time is -1. Connect time includes dns time. + // The time that establishing connection started. Connect time includes + // DNS, blocking, TCP, TCP retries and SSL time. int32 connect_start; - // The time that establishing connection ended. For reused sockets this - // time is -1. Connect time includes dns time. + // The time that establishing connection ended. Connect time includes + // DNS, blocking, TCP, TCP retries and SSL time. int32 connect_end; // The time at which SSL handshake started. For non-HTTPS requests this |