diff options
| author | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-11 22:10:53 +0000 |
|---|---|---|
| committer | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-11 22:10:53 +0000 |
| commit | 5203a4f3fc6bd8bcb2d521db09bc2625bf48c2cc (patch) | |
| tree | 27c3e90f67f600d430e1589aa88272505ba42305 /webkit/glue/webframe_impl.cc | |
| parent | 352f5f1366835c91b908c51d9d8779e35fe86caf (diff) | |
| download | chromium_src-5203a4f3fc6bd8bcb2d521db09bc2625bf48c2cc.zip chromium_src-5203a4f3fc6bd8bcb2d521db09bc2625bf48c2cc.tar.gz chromium_src-5203a4f3fc6bd8bcb2d521db09bc2625bf48c2cc.tar.bz2 | |
Relanding a backed-out CL that was thought to cause reliability test failure but that is not the culprit after-all:
The navigation entry's state would not be returned for navigation entries of
error pages (such as 404).
This was causing the following problems when navigating back to a 404 page in
test shell:
- a new entry to be created instead of going back to the existing entry
- the navTarget property not to be set on the HistoryItem
That was causing the LayoutTests/http/tests/navigation/error404-goback.html
failure.
It seems safe to return the navigation entry's state for an error page.
BUG=None
TBR=jar
Review URL: http://codereview.chromium.org/43100
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11487 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/glue/webframe_impl.cc')
| -rw-r--r-- | webkit/glue/webframe_impl.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/webkit/glue/webframe_impl.cc b/webkit/glue/webframe_impl.cc index bf4fb03..4894a7d 100644 --- a/webkit/glue/webframe_impl.cc +++ b/webkit/glue/webframe_impl.cc @@ -492,7 +492,7 @@ bool WebFrameImpl::GetPreviousHistoryState(std::string* history_state) const { // is expected to query the history state after a navigation occurs, after // the desired history item has become the previous entry. RefPtr<HistoryItem> item = webview_impl_->GetPreviousHistoryItem(); - if (!item || item->lastVisitWasFailure()) + if (!item) return false; static StatsCounterTimer history_timer("GetHistoryTimer"); |