summaryrefslogtreecommitdiffstats
path: root/webkit/glue/webframe_impl.cc
diff options
context:
space:
mode:
authordarin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-05-13 06:02:39 +0000
committerdarin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-05-13 06:02:39 +0000
commitefdb3e59f68fe34ef19dd6e52a5555e19f9b26b4 (patch)
tree717f7caca9e5b8191c0f1ff4cb1f3b00c0281e75 /webkit/glue/webframe_impl.cc
parent235df3ac876638d8f09eb62c6b8504446e19b63b (diff)
downloadchromium_src-efdb3e59f68fe34ef19dd6e52a5555e19f9b26b4.zip
chromium_src-efdb3e59f68fe34ef19dd6e52a5555e19f9b26b4.tar.gz
chromium_src-efdb3e59f68fe34ef19dd6e52a5555e19f9b26b4.tar.bz2
Re-do r15244 again.
Originally reviewed at http://codereview.chromium.org/100353 Eliminate webkit/glue/webhistoryitem* in favor of adding a NavigateBackForwardSoon method WebViewDelegate. This moves all of the hacky details of how we intercept "history.{back, forward,go}" into the webkit layer. My eventual plan is to teach WebCore how to make this not hacky. In this version of the CL, TestWebViewDelegate performs the back/forward navigation directly in NavigateBackForwardSoon instead of using PostTask to delay it. I'm doing this to minimize regressions so that I can hopefully get the rest of this CL landed. I also already made the changes to WebKit to force history. {back,forward,go} to be processed asynchronously. BUG=11423 TBR=mpcomplete Review URL: http://codereview.chromium.org/115288 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15940 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/glue/webframe_impl.cc')
-rw-r--r--webkit/glue/webframe_impl.cc15
1 files changed, 2 insertions, 13 deletions
diff --git a/webkit/glue/webframe_impl.cc b/webkit/glue/webframe_impl.cc
index 834f4a8..6976573 100644
--- a/webkit/glue/webframe_impl.cc
+++ b/webkit/glue/webframe_impl.cc
@@ -154,7 +154,6 @@ MSVC_POP_WARNING();
#include "webkit/glue/webdatasource_impl.h"
#include "webkit/glue/weberror_impl.h"
#include "webkit/glue/webframe_impl.h"
-#include "webkit/glue/webhistoryitem_impl.h"
#include "webkit/glue/weburlrequest_impl.h"
#include "webkit/glue/webtextinput_impl.h"
#include "webkit/glue/webview_impl.h"
@@ -665,25 +664,15 @@ void WebFrameImpl::CacheCurrentRequestInfo(WebDataSourceImpl* datasource) {
// own requests, so the extra data needs to be transferred.
scoped_refptr<WebRequest::ExtraData> extra;
- // Our extra data may come from a request issued via LoadRequest, or a
- // history navigation from WebCore.
- if (currently_loading_request_) {
+ // Our extra data may come from a request issued via LoadRequest.
+ if (currently_loading_request_)
extra = currently_loading_request_->GetExtraData();
- } else if (currently_loading_history_item_) {
- extra = currently_loading_history_item_->GetExtraData();
- currently_loading_history_item_ = 0;
- }
// We must only update this if it is valid, or the valid state will be lost.
if (extra)
datasource->SetExtraData(extra);
}
-void WebFrameImpl::set_currently_loading_history_item(
- WebHistoryItemImpl* item) {
- currently_loading_history_item_ = item;
-}
-
void WebFrameImpl::StopLoading() {
if (!frame_)
return;