diff options
author | darin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-07 16:44:39 +0000 |
---|---|---|
committer | darin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-07 16:44:39 +0000 |
commit | f6134ff2597f45c240b1fc2a493d38b51aa8a884 (patch) | |
tree | beddc103816d95a1f73a586eb523251154f84e6b /webkit/glue/webframe_impl.h | |
parent | 62c9a8e3985009ee3503497cb4e1ab18d8cecc97 (diff) | |
download | chromium_src-f6134ff2597f45c240b1fc2a493d38b51aa8a884.zip chromium_src-f6134ff2597f45c240b1fc2a493d38b51aa8a884.tar.gz chromium_src-f6134ff2597f45c240b1fc2a493d38b51aa8a884.tar.bz2 |
Modify ResourceFetcher to use WebURLLoader instead of ResourceHandle.
This is step 1 of moving ResourceFetcher usage out of WebFrame. This
CL adds a new method to WebFrame, named DispatchWillSendRequest, which
may be used to associate a WebURLRequest with the WebFrame. This
triggers the WebViewDelegate's WillSendRequest method among other things.
ResourceFetcher and friends have been modified to use callbacks instead
of delegates. I just find this approach a bit cleaner and easier to
work with.
BUG=15648
TEST=none
R=brettw
Review URL: http://codereview.chromium.org/149172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20031 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/glue/webframe_impl.h')
-rw-r--r-- | webkit/glue/webframe_impl.h | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/webkit/glue/webframe_impl.h b/webkit/glue/webframe_impl.h index 4919a0b..f22f58b 100644 --- a/webkit/glue/webframe_impl.h +++ b/webkit/glue/webframe_impl.h @@ -39,7 +39,6 @@ MSVC_PUSH_WARNING_LEVEL(0); #include "PlatformString.h" MSVC_POP_WARNING(); -class AltErrorPageResourceFetcher; class ChromePrintContext; class WebDataSourceImpl; class WebPluginDelegate; @@ -48,6 +47,10 @@ class WebViewImpl; class WebTextInput; class WebTextInputImpl; +namespace gfx { +class BitmapPlatformDevice; +} + namespace WebCore { class Frame; class FrameView; @@ -59,8 +62,8 @@ class SubstituteData; struct WindowFeatures; } -namespace gfx { -class BitmapPlatformDevice; +namespace webkit_glue { +class AltErrorPageResourceFetcher; } // Implementation of WebFrame, note that this is a reference counted object. @@ -98,6 +101,7 @@ class WebFrameImpl : public WebFrame, public base::RefCounted<WebFrameImpl> { const GURL& error_page_url, bool replace, const GURL& fake_url); + virtual void DispatchWillSendRequest(WebKit::WebURLRequest* request); virtual void ExecuteScript(const WebKit::WebScriptSource& source); virtual void ExecuteScriptInNewContext( const WebKit::WebScriptSource* sources, int num_sources); @@ -280,7 +284,7 @@ class WebFrameImpl : public WebFrame, public base::RefCounted<WebFrameImpl> { int request_id); // Resource fetcher for downloading an alternate DNS error page. - scoped_ptr<AltErrorPageResourceFetcher> alt_error_page_fetcher_; + scoped_ptr<webkit_glue::AltErrorPageResourceFetcher> alt_error_page_fetcher_; // Used to check for leaks of this object. static int live_object_count_; |