diff options
| author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-26 19:39:29 +0000 |
|---|---|---|
| committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-26 19:39:29 +0000 |
| commit | 096d5cdd6c7b6930ca4a59bb965b5e4f6647f8e0 (patch) | |
| tree | b59e549c2ae6733f3d675a8982d109088adcea51 /webkit/glue/webplugin.h | |
| parent | 540f91b592b8a500442bccdebffbd34a4d8bc1bd (diff) | |
| download | chromium_src-096d5cdd6c7b6930ca4a59bb965b5e4f6647f8e0.zip chromium_src-096d5cdd6c7b6930ca4a59bb965b5e4f6647f8e0.tar.gz chromium_src-096d5cdd6c7b6930ca4a59bb965b5e4f6647f8e0.tar.bz2 | |
Report the plugin position to windowed plugins as (0,0)
. the NPAPI documentation says it should be reported relative to the parent HWND, which is the plugin's coordinates on the page. This assumption breaks in Chrome because we have an intermediate HWND. I've tested on a bunch of pages to see if this change causes regressions, if we find any in the future we can reconsider this.
BUG=6742
Review URL: http://codereview.chromium.org/42626
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12587 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/glue/webplugin.h')
| -rw-r--r-- | webkit/glue/webplugin.h | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/webkit/glue/webplugin.h b/webkit/glue/webplugin.h index c9b9251..814839a 100644 --- a/webkit/glue/webplugin.h +++ b/webkit/glue/webplugin.h @@ -89,7 +89,10 @@ class WebPlugin { // The pump_messages_event is a event handle which is valid only for // windowless plugins and is used in NPP_HandleEvent calls to pump messages // if the plugin enters a modal loop. - virtual void SetWindow(gfx::NativeView window, + // The return value is only valid for windowed plugins. If true, it means + // that the the HWND position should be managed by the delegate. If false, + // the plugin should be kept at the origin and it'll get moved elsewhere. + virtual bool SetWindow(gfx::NativeView window, HANDLE pump_messages_event) = 0; // Cancels a pending request. virtual void CancelResource(int id) = 0; |