summaryrefslogtreecommitdiffstats
path: root/webkit/glue/webplugin_impl.cc
diff options
context:
space:
mode:
authordarin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-08-26 17:17:58 +0000
committerdarin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-08-26 17:17:58 +0000
commit16f89d074dd62b9850adfc988c02e385da465124 (patch)
tree2e90f306726888d1e955ab8e5f00a71aa5d4935a /webkit/glue/webplugin_impl.cc
parent4a12e4cc0c9daad8dd006c5cfadd331f2a46b76b (diff)
downloadchromium_src-16f89d074dd62b9850adfc988c02e385da465124.zip
chromium_src-16f89d074dd62b9850adfc988c02e385da465124.tar.gz
chromium_src-16f89d074dd62b9850adfc988c02e385da465124.tar.bz2
Add isVisible parameter to WebPlugin::updateGeometry.
This allows for geometry updates while the plugin is hidden so that when it becomes visible, the plugin is properly positioned. In this change, I also revised RenderWidget::SchedulePluginMove to properly merge a move that only updates the visible state, and I fixed up TestShell to properly handle moves that only update the visible state. R=jam BUG=19888,20260 TEST=covered by layout tests Review URL: http://codereview.chromium.org/174513 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24457 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/glue/webplugin_impl.cc')
-rw-r--r--webkit/glue/webplugin_impl.cc4
1 files changed, 2 insertions, 2 deletions
diff --git a/webkit/glue/webplugin_impl.cc b/webkit/glue/webplugin_impl.cc
index 397fbd2..d10cf6c 100644
--- a/webkit/glue/webplugin_impl.cc
+++ b/webkit/glue/webplugin_impl.cc
@@ -285,7 +285,7 @@ void WebPluginImpl::paint(WebCanvas* canvas, const WebRect& paint_rect) {
void WebPluginImpl::updateGeometry(
const WebRect& window_rect, const WebRect& clip_rect,
- const WebVector<WebRect>& cutout_rects) {
+ const WebVector<WebRect>& cutout_rects, bool is_visible) {
if (window_) {
WebViewDelegate* view_delegate = GetWebViewDelegate();
if (view_delegate) {
@@ -299,7 +299,7 @@ void WebPluginImpl::updateGeometry(
for (size_t i = 0; i < cutout_rects.size(); ++i)
move.cutout_rects.push_back(cutout_rects[i]);
move.rects_valid = true;
- move.visible = true; // Assume visible or else we wouldn't be here.
+ move.visible = is_visible;
view_delegate->DidMovePlugin(move);
}