diff options
| author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-26 19:39:29 +0000 |
|---|---|---|
| committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-26 19:39:29 +0000 |
| commit | 096d5cdd6c7b6930ca4a59bb965b5e4f6647f8e0 (patch) | |
| tree | b59e549c2ae6733f3d675a8982d109088adcea51 /webkit/glue/webplugin_impl.cc | |
| parent | 540f91b592b8a500442bccdebffbd34a4d8bc1bd (diff) | |
| download | chromium_src-096d5cdd6c7b6930ca4a59bb965b5e4f6647f8e0.zip chromium_src-096d5cdd6c7b6930ca4a59bb965b5e4f6647f8e0.tar.gz chromium_src-096d5cdd6c7b6930ca4a59bb965b5e4f6647f8e0.tar.bz2 | |
Report the plugin position to windowed plugins as (0,0)
. the NPAPI documentation says it should be reported relative to the parent HWND, which is the plugin's coordinates on the page. This assumption breaks in Chrome because we have an intermediate HWND. I've tested on a bunch of pages to see if this change causes regressions, if we find any in the future we can reconsider this.
BUG=6742
Review URL: http://codereview.chromium.org/42626
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12587 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/glue/webplugin_impl.cc')
| -rw-r--r-- | webkit/glue/webplugin_impl.cc | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/webkit/glue/webplugin_impl.cc b/webkit/glue/webplugin_impl.cc index 0a56271..e822cfc 100644 --- a/webkit/glue/webplugin_impl.cc +++ b/webkit/glue/webplugin_impl.cc @@ -336,7 +336,7 @@ WebPluginImpl::WebPluginImpl(WebCore::HTMLPlugInElement* element, WebPluginImpl::~WebPluginImpl() { } -void WebPluginImpl::SetWindow(gfx::NativeView window, +bool WebPluginImpl::SetWindow(gfx::NativeView window, HANDLE pump_messages_event) { if (window) { DCHECK(!windowless_); // Make sure not called twice. @@ -345,6 +345,8 @@ void WebPluginImpl::SetWindow(gfx::NativeView window, DCHECK(!window_); // Make sure not called twice. windowless_ = true; } + + return true; } bool WebPluginImpl::CompleteURL(const std::string& url_in, |