diff options
| author | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-09 06:03:45 +0000 |
|---|---|---|
| committer | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-09 06:03:45 +0000 |
| commit | 253071feeaf010115a8fbe498d1ebd634c2d1626 (patch) | |
| tree | 356ae73b564b4f4bf3917c37e6458d12b047fd07 /webkit/glue/webview_impl.cc | |
| parent | fe884d10d8f769f9cd52c24b41f791fc176ff3e5 (diff) | |
| download | chromium_src-253071feeaf010115a8fbe498d1ebd634c2d1626.zip chromium_src-253071feeaf010115a8fbe498d1ebd634c2d1626.tar.gz chromium_src-253071feeaf010115a8fbe498d1ebd634c2d1626.tar.bz2 | |
One of my recent CL added triggering form autofill when clicking an already focused text-field.
It was triggering form autofill or password autofill indiscriminately, causing a regression: double clicking a login text-field would trigger password autofill preventing the expected behavior of selecting the text in the text-field. Only form autofill is expected to be triggered in that case.
BUG=9544
TEST=Open a page with a login form for which you have saved a password. Double-click the login text-field, this should select all the text. Ensure the form autocomplete still works as expected.
Review URL: http://codereview.chromium.org/62143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13408 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/glue/webview_impl.cc')
| -rw-r--r-- | webkit/glue/webview_impl.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/webkit/glue/webview_impl.cc b/webkit/glue/webview_impl.cc index 440830f..c98ac6f 100644 --- a/webkit/glue/webview_impl.cc +++ b/webkit/glue/webview_impl.cc @@ -459,7 +459,7 @@ void WebViewImpl::MouseDown(const WebMouseEvent& event) { if (clicked_node.get() && clicked_node == GetFocusedNode()) { // Focus has not changed, show the autocomplete popup. static_cast<EditorClientImpl*>(page_->editorClient())-> - ShowAutofillForNode(clicked_node.get()); + ShowFormAutofillForNode(clicked_node.get()); } // Dispatch the contextmenu event regardless of if the click was swallowed. |