diff options
author | darin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-09 18:55:20 +0000 |
---|---|---|
committer | darin@chromium.org <darin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-07-09 18:55:20 +0000 |
commit | d8f8a5949f1e5cd15058ade51296ca620d456736 (patch) | |
tree | 7326269d7822788cd3c3209cc460670f62547449 /webkit/glue/webview_impl.h | |
parent | 01fab8b94bf539331104f3e2adffc4933766d362 (diff) | |
download | chromium_src-d8f8a5949f1e5cd15058ade51296ca620d456736.zip chromium_src-d8f8a5949f1e5cd15058ade51296ca620d456736.tar.gz chromium_src-d8f8a5949f1e5cd15058ade51296ca620d456736.tar.bz2 |
Remove reference counting from WebWidgetDelegate.
This was added as a speculative crash fix by eseidel back in June of 2008. See
http://b/1211911 for details. It didn't appear to resolve the crash then (as
another patch was required to fix the bug), and it doesn't seem to be necessary
since the RenderView, which is the delegate and owns the WebView, is the one in
charge of allocating the WebView and destroying the WebView. So, it is not
possible for the WebView to outlive the RenderView.
BUG=16234
TEST=none
R=brettw
Review URL: http://codereview.chromium.org/155292
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20294 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/glue/webview_impl.h')
-rw-r--r-- | webkit/glue/webview_impl.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/webkit/glue/webview_impl.h b/webkit/glue/webview_impl.h index ac85c06..d55df1a 100644 --- a/webkit/glue/webview_impl.h +++ b/webkit/glue/webview_impl.h @@ -144,7 +144,7 @@ class WebViewImpl : public WebView, public base::RefCounted<WebViewImpl> { static WebViewImpl* FromPage(WebCore::Page* page); WebViewDelegate* delegate() { - return delegate_.get(); + return delegate_; } // Returns the page object associated with this view. This may be NULL when @@ -228,7 +228,7 @@ class WebViewImpl : public WebView, public base::RefCounted<WebViewImpl> { WebCore::Frame* frame, const WebCore::PlatformKeyboardEvent& e); - scoped_refptr<WebViewDelegate> delegate_; + WebViewDelegate* delegate_; WebKit::WebSize size_; WebKit::WebPoint last_mouse_position_; |