diff options
| author | hbono@chromium.org <hbono@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-11-06 07:40:53 +0000 |
|---|---|---|
| committer | hbono@chromium.org <hbono@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-11-06 07:40:53 +0000 |
| commit | 34f6bc1937fe617875e8f5e95485904569cca582 (patch) | |
| tree | 94f201b6bb78ff601a8a97783f4ac0134423af48 /webkit/glue/webwidget_impl.h | |
| parent | 576d8bff4e6778c6de60b8a7269a78c5e8bf602a (diff) | |
| download | chromium_src-34f6bc1937fe617875e8f5e95485904569cca582.zip chromium_src-34f6bc1937fe617875e8f5e95485904569cca582.tar.gz chromium_src-34f6bc1937fe617875e8f5e95485904569cca582.tar.bz2 | |
Changes parameters used by IME code to fix several issues caused by Japanese IMEs.
Recent Japanese IMEs (ATOK2008 and MSIME 2007) display a suggestion window (a window which contains suggestions) above a composition string. To fix this issue, we do not only send the lower-left corner of a composition string but also send its upper-left corner and its upper-right corner. So, this change changes IPC parameters used by IME from a tuple of integers to gfx::Rect.
Also, this change fixes cursor positions for Japanese IMEs.
BUG=2770 "IME: Candidate window of Japanese IME follows the end of composition"
BUG=2771 "ATOK 2008 IME pop-ups are displayed below the main Chrome window."
BUG=2775 "IME: Caret is always displayed at the last of IME composition."
Review URL: http://codereview.chromium.org/7385
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4872 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/glue/webwidget_impl.h')
| -rw-r--r-- | webkit/glue/webwidget_impl.h | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/webkit/glue/webwidget_impl.h b/webkit/glue/webwidget_impl.h index 1c8a9a2..c19e6a2e 100644 --- a/webkit/glue/webwidget_impl.h +++ b/webkit/glue/webwidget_impl.h @@ -41,12 +41,14 @@ class WebWidgetImpl : public WebWidget, virtual bool HandleInputEvent(const WebInputEvent* input_event); virtual void MouseCaptureLost(); virtual void SetFocus(bool enable); - virtual void ImeSetComposition(int string_type, int cursor_position, - int target_start, int target_end, - int string_length, - const wchar_t *string_data); - virtual bool ImeUpdateStatus(bool* enable_ime, const void** id, - int* x, int* y); + virtual bool ImeSetComposition(int string_type, + int cursor_position, + int target_start, + int target_end, + const std::wstring& ime_string); + virtual bool ImeUpdateStatus(bool* enable_ime, + const void** node, + gfx::Rect* caret_rect); // WebWidgetImpl void Init(WebCore::FramelessScrollView* widget, const gfx::Rect& bounds); |