diff options
| author | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-05 04:48:53 +0000 |
|---|---|---|
| committer | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-05 04:48:53 +0000 |
| commit | 81ce9f3b1eb34dc7f6954f0f6657a76b0f01fc12 (patch) | |
| tree | 41b3caf1a55ba3cfa2f6cf13b0a5ce3d773d631f /webkit/glue | |
| parent | 4f7f4854821e8e4933ad2c662bfd9417eb604a68 (diff) | |
| download | chromium_src-81ce9f3b1eb34dc7f6954f0f6657a76b0f01fc12.zip chromium_src-81ce9f3b1eb34dc7f6954f0f6657a76b0f01fc12.tar.gz chromium_src-81ce9f3b1eb34dc7f6954f0f6657a76b0f01fc12.tar.bz2 | |
Use lock-free lazy initialization for static histogram references
Make all histogram macros thread safe, and fast by again
using statics to achieve performance.
...at the cost of:
Leak all histograms to avoid races at shutdown.
Also included leak suppression for valgrind.
r=rtenneti
BUG=78207
Review URL: http://codereview.chromium.org/6780035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80412 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/glue')
| -rw-r--r-- | webkit/glue/webkitclient_impl.cc | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/webkit/glue/webkitclient_impl.cc b/webkit/glue/webkitclient_impl.cc index 4fc05e6..4e2b10a 100644 --- a/webkit/glue/webkitclient_impl.cc +++ b/webkit/glue/webkitclient_impl.cc @@ -264,24 +264,22 @@ void WebKitClientImpl::histogramCustomCounts( const char* name, int sample, int min, int max, int bucket_count) { // Copied from histogram macro, but without the static variable caching // the histogram because name is dynamic. - scoped_refptr<base::Histogram> counter = + base::Histogram* counter = base::Histogram::FactoryGet(name, min, max, bucket_count, base::Histogram::kUmaTargetedHistogramFlag); DCHECK_EQ(name, counter->histogram_name()); - if (counter.get()) - counter->Add(sample); + counter->Add(sample); } void WebKitClientImpl::histogramEnumeration( const char* name, int sample, int boundary_value) { // Copied from histogram macro, but without the static variable caching // the histogram because name is dynamic. - scoped_refptr<base::Histogram> counter = + base::Histogram* counter = base::LinearHistogram::FactoryGet(name, 1, boundary_value, boundary_value + 1, base::Histogram::kUmaTargetedHistogramFlag); DCHECK_EQ(name, counter->histogram_name()); - if (counter.get()) - counter->Add(sample); + counter->Add(sample); } void WebKitClientImpl::traceEventBegin(const char* name, void* id, |