summaryrefslogtreecommitdiffstats
path: root/webkit/glue
diff options
context:
space:
mode:
authorvsevik@chromium.org <vsevik@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-03-31 19:01:48 +0000
committervsevik@chromium.org <vsevik@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-03-31 19:01:48 +0000
commitc7d5601fa3df36215e46de17d5699b40bce82fa4 (patch)
tree351e51d291a64939e25a14a6e78f2ec9f88e3906 /webkit/glue
parentc4bc58d55fb1b29f69fc1bccc93b74e56c99b010 (diff)
downloadchromium_src-c7d5601fa3df36215e46de17d5699b40bce82fa4.zip
chromium_src-c7d5601fa3df36215e46de17d5699b40bce82fa4.tar.gz
chromium_src-c7d5601fa3df36215e46de17d5699b40bce82fa4.tar.bz2
Migrated chromium to new didReceiveData method in WebURLLoaderClient
BUG=40502 Review URL: http://codereview.chromium.org/6737026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80039 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/glue')
-rw-r--r--webkit/glue/ftp_directory_listing_response_delegate.cc2
-rw-r--r--webkit/glue/media/buffered_resource_loader.cc10
-rw-r--r--webkit/glue/media/buffered_resource_loader.h10
-rw-r--r--webkit/glue/media/buffered_resource_loader_unittest.cc6
-rw-r--r--webkit/glue/multipart_response_delegate.cc17
-rw-r--r--webkit/glue/multipart_response_delegate_unittest.cc15
-rw-r--r--webkit/glue/resource_fetcher.cc8
-rw-r--r--webkit/glue/resource_fetcher.h6
-rw-r--r--webkit/glue/weburlloader_impl.cc3
9 files changed, 63 insertions, 14 deletions
diff --git a/webkit/glue/ftp_directory_listing_response_delegate.cc b/webkit/glue/ftp_directory_listing_response_delegate.cc
index a94d299..20be2b8 100644
--- a/webkit/glue/ftp_directory_listing_response_delegate.cc
+++ b/webkit/glue/ftp_directory_listing_response_delegate.cc
@@ -110,7 +110,7 @@ void FtpDirectoryListingResponseDelegate::Init(const GURL& response_url) {
void FtpDirectoryListingResponseDelegate::SendDataToClient(
const std::string& data) {
- client_->didReceiveData(loader_, data.data(), data.length());
+ client_->didReceiveData2(loader_, data.data(), data.length(), -1);
}
} // namespace webkit_glue
diff --git a/webkit/glue/media/buffered_resource_loader.cc b/webkit/glue/media/buffered_resource_loader.cc
index c6295bf..5adb76f 100644
--- a/webkit/glue/media/buffered_resource_loader.cc
+++ b/webkit/glue/media/buffered_resource_loader.cc
@@ -318,10 +318,20 @@ void BufferedResourceLoader::didReceiveResponse(
DoneStart(net::OK);
}
+// FIXME(vsevik): remove once removed in webkit
void BufferedResourceLoader::didReceiveData(
WebURLLoader* loader,
const char* data,
int data_length) {
+ didReceiveData2(loader, data, data_length, -1);
+}
+
+// FIXME(vsevik): rename once renamed in webkit
+void BufferedResourceLoader::didReceiveData2(
+ WebURLLoader* loader,
+ const char* data,
+ int data_length,
+ int length_received) {
DCHECK(!completed_);
DCHECK_GT(data_length, 0);
diff --git a/webkit/glue/media/buffered_resource_loader.h b/webkit/glue/media/buffered_resource_loader.h
index 4d76adc..3e04b43 100644
--- a/webkit/glue/media/buffered_resource_loader.h
+++ b/webkit/glue/media/buffered_resource_loader.h
@@ -124,7 +124,15 @@ class BufferedResourceLoader :
const WebKit::WebURLResponse& response);
virtual void didDownloadData(
WebKit::WebURLLoader* loader,
- int dataLength);
+ int data_length);
+ // FIXME(vsevik): rename once renamed in webkit
+ virtual void didReceiveData2(
+ WebKit::WebURLLoader* loader,
+ const char* data,
+ int data_length,
+ int length_received);
+
+ // FIXME(vsevik): remove once removed in webkit
virtual void didReceiveData(
WebKit::WebURLLoader* loader,
const char* data,
diff --git a/webkit/glue/media/buffered_resource_loader_unittest.cc b/webkit/glue/media/buffered_resource_loader_unittest.cc
index aef44ca..bb6e7d9 100644
--- a/webkit/glue/media/buffered_resource_loader_unittest.cc
+++ b/webkit/glue/media/buffered_resource_loader_unittest.cc
@@ -159,8 +159,10 @@ class BufferedResourceLoaderTest : public testing::Test {
void WriteLoader(int position, int size) {
EXPECT_CALL(*this, NetworkCallback())
.RetiresOnSaturation();
- loader_->didReceiveData(url_loader_,
- reinterpret_cast<char*>(data_ + position), size);
+ // FIXME(vsevik): rename once renamed in webkit
+ loader_->didReceiveData2(url_loader_,
+ reinterpret_cast<char*>(data_ + position), size,
+ size);
}
// Helper method to read from |loader_|.
diff --git a/webkit/glue/multipart_response_delegate.cc b/webkit/glue/multipart_response_delegate.cc
index d2c47d7..a32520e 100644
--- a/webkit/glue/multipart_response_delegate.cc
+++ b/webkit/glue/multipart_response_delegate.cc
@@ -138,9 +138,10 @@ void MultipartResponseDelegate::OnReceivedData(const char* data,
}
if (data_length > 0) {
// Send the last data chunk.
- client_->didReceiveData(loader_,
- data_.data(),
- static_cast<int>(data_length));
+ // FIXME(vsevik): rename once renamed in webkit
+ client_->didReceiveData2(loader_,
+ data_.data(),
+ static_cast<int>(data_length), -1);
}
}
size_t boundary_end_pos = boundary_pos + boundary_.length();
@@ -170,8 +171,9 @@ void MultipartResponseDelegate::OnReceivedData(const char* data,
int send_length = data_.length() - boundary_.length();
if (data_[data_.length() - 1] == '\n')
send_length = data_.length();
+ // FIXME(vsevik): rename didReceiveData2 once renamed in webkit
if (client_)
- client_->didReceiveData(loader_, data_.data(), send_length);
+ client_->didReceiveData2(loader_, data_.data(), send_length, -1);
data_ = data_.substr(send_length);
}
}
@@ -180,9 +182,10 @@ void MultipartResponseDelegate::OnCompletedRequest() {
// If we have any pending data and we're not in a header, go ahead and send
// it to WebCore.
if (!processing_headers_ && !data_.empty() && !stop_sending_ && client_) {
- client_->didReceiveData(loader_,
- data_.data(),
- static_cast<int>(data_.length()));
+ // FIXME(vsevik): rename didReceiveData2 once renamed in webkit
+ client_->didReceiveData2(loader_,
+ data_.data(),
+ static_cast<int>(data_.length()), -1);
}
}
diff --git a/webkit/glue/multipart_response_delegate_unittest.cc b/webkit/glue/multipart_response_delegate_unittest.cc
index fbefaaa..c48c2de 100644
--- a/webkit/glue/multipart_response_delegate_unittest.cc
+++ b/webkit/glue/multipart_response_delegate_unittest.cc
@@ -66,12 +66,23 @@ class MockWebURLLoaderClient : public WebURLLoaderClient {
response_ = response;
data_.clear();
}
- virtual void didReceiveData(WebURLLoader* loader,
- const char* data, int data_length) {
+ // FIXME(vsevik): rename once renamed in webkit
+ virtual void didReceiveData2(
+ WebKit::WebURLLoader* loader,
+ const char* data,
+ int data_length,
+ int length_received) {
++received_data_;
data_.append(data, data_length);
}
+ // FIXME(vsevik): remove once removed in webkit
+ virtual void didReceiveData(
+ WebKit::WebURLLoader* loader,
+ const char* data,
+ int data_length) {
+ didReceiveData2(loader, data, data_length, -1);
+ }
virtual void didFinishLoading(WebURLLoader*, double finishTime) {}
virtual void didFail(WebURLLoader*, const WebURLError&) {}
diff --git a/webkit/glue/resource_fetcher.cc b/webkit/glue/resource_fetcher.cc
index 39cc59c..b0ee667 100644
--- a/webkit/glue/resource_fetcher.cc
+++ b/webkit/glue/resource_fetcher.cc
@@ -84,8 +84,16 @@ void ResourceFetcher::didReceiveResponse(
response_ = response;
}
+// FIXME(vsevik): remove once removed in webkit
void ResourceFetcher::didReceiveData(
WebURLLoader* loader, const char* data, int data_length) {
+ didReceiveData2(loader, data, data_length, -1);
+}
+
+// FIXME(vsevik): rename once renamed in webkit
+void ResourceFetcher::didReceiveData2(
+ WebURLLoader* loader, const char* data, int data_length,
+ int length_received) {
DCHECK(!completed_);
DCHECK(data_length > 0);
diff --git a/webkit/glue/resource_fetcher.h b/webkit/glue/resource_fetcher.h
index a814b41..726e279 100644
--- a/webkit/glue/resource_fetcher.h
+++ b/webkit/glue/resource_fetcher.h
@@ -63,8 +63,14 @@ class ResourceFetcher : public WebKit::WebURLLoaderClient {
WebKit::WebURLLoader* loader, const WebKit::WebURLResponse& response);
virtual void didReceiveCachedMetadata(
WebKit::WebURLLoader* loader, const char* data, int data_length);
+
+ // FIXME(vsevik): remove once removed in webkit
virtual void didReceiveData(
WebKit::WebURLLoader* loader, const char* data, int data_length);
+ // FIXME(vsevik): rename once renamed in webkit
+ virtual void didReceiveData2(
+ WebKit::WebURLLoader* loader, const char* data, int data_length,
+ int length_received);
virtual void didFinishLoading(
WebKit::WebURLLoader* loader, double finishTime);
virtual void didFail(
diff --git a/webkit/glue/weburlloader_impl.cc b/webkit/glue/weburlloader_impl.cc
index 48813b5..6182815 100644
--- a/webkit/glue/weburlloader_impl.cc
+++ b/webkit/glue/weburlloader_impl.cc
@@ -606,7 +606,8 @@ void WebURLLoaderImpl::Context::OnReceivedData(const char* data, int len) {
// client_->didReceiveData and client_->didReceiveResponse.
multipart_delegate_->OnReceivedData(data, len);
} else {
- client_->didReceiveData(loader_, data, len);
+ // FIXME(vsevik): rename once renamed in webkit
+ client_->didReceiveData2(loader_, data, len, -1);
}
}