diff options
| author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-16 21:38:44 +0000 |
|---|---|---|
| committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-16 21:38:44 +0000 |
| commit | 812eaca72f309bcbb51ee8f386a7d33429c3a314 (patch) | |
| tree | 572dc7d913f288b2b6dc380ee918b479e9067158 /webkit/glue | |
| parent | 328bfdc4f0bada557e329c3f477c8947c8a8aa17 (diff) | |
| download | chromium_src-812eaca72f309bcbb51ee8f386a7d33429c3a314.zip chromium_src-812eaca72f309bcbb51ee8f386a7d33429c3a314.tar.gz chromium_src-812eaca72f309bcbb51ee8f386a7d33429c3a314.tar.bz2 | |
This fixes bug http://code.google.com/p/chromium/issues/detail?id=2952, which was
a plugin layout test failure (return-error-from-new-stream-doesnt-invoke-destroy-stream.html)
The test fails because it assumes that if an error is returned from NPP_NewStream, NPP_URLNotify
is still invoked thus sending a notification to the plugin. The plugin implementation in webkit
does this.
We emulate this behavior.
Bug=2952
R=jam
Review URL: http://codereview.chromium.org/7443
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3489 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/glue')
| -rw-r--r-- | webkit/glue/plugins/plugin_stream.cc | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/webkit/glue/plugins/plugin_stream.cc b/webkit/glue/plugins/plugin_stream.cc index 9cdeb3b..1d00b25 100644 --- a/webkit/glue/plugins/plugin_stream.cc +++ b/webkit/glue/plugins/plugin_stream.cc @@ -83,8 +83,10 @@ bool PluginStream::Open(const std::string &mime_type, NPError err = instance_->NPP_NewStream((NPMIMEType)char_mime_type, &stream_, seekable_stream, &requested_plugin_mode_); - if (err != NPERR_NO_ERROR) + if (err != NPERR_NO_ERROR) { + Notify(err); return false; + } opened_ = true; |