diff options
author | scherkus@chromium.org <scherkus@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-26 17:26:44 +0000 |
---|---|---|
committer | scherkus@chromium.org <scherkus@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-06-26 17:26:44 +0000 |
commit | 9668838dea335d279409c621ede1730624acf7af (patch) | |
tree | 435adb270d282dce74e4d1e0bd7cb309ab9553a4 /webkit/glue | |
parent | e457b150e965030f9a032ebc24292f2014631441 (diff) | |
download | chromium_src-9668838dea335d279409c621ede1730624acf7af.zip chromium_src-9668838dea335d279409c621ede1730624acf7af.tar.gz chromium_src-9668838dea335d279409c621ede1730624acf7af.tar.bz2 |
Micro-refactor: added VideoRendererBase::OnStop().
Updated subclasses WtlRenderer and VideoRendererImpl as well.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/147191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19372 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/glue')
-rw-r--r-- | webkit/glue/media/video_renderer_impl.cc | 10 | ||||
-rw-r--r-- | webkit/glue/media/video_renderer_impl.h | 6 |
2 files changed, 8 insertions, 8 deletions
diff --git a/webkit/glue/media/video_renderer_impl.cc b/webkit/glue/media/video_renderer_impl.cc index 15f4c16..9137fb3 100644 --- a/webkit/glue/media/video_renderer_impl.cc +++ b/webkit/glue/media/video_renderer_impl.cc @@ -25,10 +25,6 @@ bool VideoRendererImpl::IsMediaFormatSupported( return ParseMediaFormat(media_format, &width, &height); } -void VideoRendererImpl::Stop() { - VideoRendererBase::Stop(); - delegate_->SetVideoRenderer(NULL); -} bool VideoRendererImpl::OnInitialize(media::VideoDecoder* decoder) { int width = 0; @@ -47,13 +43,17 @@ bool VideoRendererImpl::OnInitialize(media::VideoDecoder* decoder) { return false; } -void VideoRendererImpl::SetRect(const gfx::Rect& rect) { +void VideoRendererImpl::OnStop() { + delegate_->SetVideoRenderer(NULL); } void VideoRendererImpl::OnFrameAvailable() { delegate_->PostRepaintTask(); } +void VideoRendererImpl::SetRect(const gfx::Rect& rect) { +} + // This method is always called on the renderer's thread. void VideoRendererImpl::Paint(skia::PlatformCanvas* canvas, const gfx::Rect& dest_rect) { diff --git a/webkit/glue/media/video_renderer_impl.h b/webkit/glue/media/video_renderer_impl.h index b807054..ee251a5 100644 --- a/webkit/glue/media/video_renderer_impl.h +++ b/webkit/glue/media/video_renderer_impl.h @@ -50,13 +50,13 @@ class VideoRendererImpl : public media::VideoRendererBase { // FilterFactoryImpl1 implementation. static bool IsMediaFormatSupported(const media::MediaFormat& media_format); - // Override VideoRendererBase implementation of Stop(). - virtual void Stop(); - protected: // Method called by VideoRendererBase during initialization. virtual bool OnInitialize(media::VideoDecoder* decoder); + // Method called by the VideoRendererBase when stopping. + virtual void OnStop(); + // Method called by the VideoRendererBase when a frame is available. virtual void OnFrameAvailable(); |