diff options
author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-05 00:10:06 +0000 |
---|---|---|
committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-05 00:10:06 +0000 |
commit | ed4bf2dbceed9daaf6401e6e65701d4e51798953 (patch) | |
tree | 0b1f193c8a0b77b47424508d1b7c35ff03f13d6d /webkit/glue | |
parent | b42850f1e2b9875f491be41154cf23e773894ba3 (diff) | |
download | chromium_src-ed4bf2dbceed9daaf6401e6e65701d4e51798953.zip chromium_src-ed4bf2dbceed9daaf6401e6e65701d4e51798953.tar.gz chromium_src-ed4bf2dbceed9daaf6401e6e65701d4e51798953.tar.bz2 |
Various trivial clean-up bits:
* Fix an 80-column issue
* Remove an unused param
* Remove an unnecessary setter
* Fix a variable capitalization style violation
Review URL: http://codereview.chromium.org/100361
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15254 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'webkit/glue')
-rw-r--r-- | webkit/glue/chrome_client_impl.cc | 6 | ||||
-rw-r--r-- | webkit/glue/webview_delegate.h | 2 | ||||
-rw-r--r-- | webkit/glue/webwidget_delegate.h | 6 |
3 files changed, 8 insertions, 6 deletions
diff --git a/webkit/glue/chrome_client_impl.cc b/webkit/glue/chrome_client_impl.cc index 573a3b2..9a823a9 100644 --- a/webkit/glue/chrome_client_impl.cc +++ b/webkit/glue/chrome_client_impl.cc @@ -169,9 +169,9 @@ WebCore::Page* ChromeClientImpl::createWindow( if (!delegate) return NULL; - bool userGesture = frame->script()->processingUserGesture(); + bool user_gesture = frame->script()->processingUserGesture(); WebViewImpl* new_view = static_cast<WebViewImpl*>( - delegate->CreateWebView(webview_, userGesture)); + delegate->CreateWebView(webview_, user_gesture)); if (!new_view) return NULL; @@ -211,7 +211,7 @@ void ChromeClientImpl::show() { !scrollbars_visible_ || !menubar_visible_ || !resizable_ || - !delegate->WasOpenedByUserGesture(webview_); + !delegate->WasOpenedByUserGesture(); WindowOpenDisposition disposition = NEW_FOREGROUND_TAB; if (as_popup) diff --git a/webkit/glue/webview_delegate.h b/webkit/glue/webview_delegate.h index 27036db..29c31be 100644 --- a/webkit/glue/webview_delegate.h +++ b/webkit/glue/webview_delegate.h @@ -159,7 +159,7 @@ class WebViewDelegate : virtual public WebWidgetDelegate { } // Returns whether this WebView was opened by a user gesture. - virtual bool WasOpenedByUserGesture(WebView* webview) const { + virtual bool WasOpenedByUserGesture() const { return true; } diff --git a/webkit/glue/webwidget_delegate.h b/webkit/glue/webwidget_delegate.h index 5b8fbbd0..9dc79b3 100644 --- a/webkit/glue/webwidget_delegate.h +++ b/webkit/glue/webwidget_delegate.h @@ -54,8 +54,10 @@ class WebWidgetDelegate { // This method is called to instruct the window containing the WebWidget to // show itself as the topmost window. This method is only used after a // successful call to CreateWebWidget. |disposition| indicates how this new - // window should be displayed, but generally only means something for WebViews. - virtual void Show(WebWidget* webwidget, WindowOpenDisposition disposition) = 0; + // window should be displayed, but generally only means something for + // WebViews. + virtual void Show(WebWidget* webwidget, + WindowOpenDisposition disposition) = 0; // Used for displaying HTML popup menus on Mac OS X (other platforms will use // Show() above). |bounds| represents the positioning on the screen (in WebKit |